From 25ecf9eafbeb0fcd68b5643fe21b5fba871e8b05 Mon Sep 17 00:00:00 2001 From: Quentin Lemaire Date: Tue, 29 Dec 2020 10:59:09 +0100 Subject: [PATCH] fix(cmd_tag): Use restic.TagLists --- cmd/restic/cmd_tag.go | 8 ++++---- cmd/restic/integration_test.go | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/cmd/restic/cmd_tag.go b/cmd/restic/cmd_tag.go index 4ff94b01d..13842c077 100644 --- a/cmd/restic/cmd_tag.go +++ b/cmd/restic/cmd_tag.go @@ -38,9 +38,9 @@ type TagOptions struct { Hosts []string Paths []string Tags restic.TagLists - SetTags restic.TagList - AddTags restic.TagList - RemoveTags restic.TagList + SetTags restic.TagLists + AddTags restic.TagLists + RemoveTags restic.TagLists } var tagOptions TagOptions @@ -130,7 +130,7 @@ func runTag(opts TagOptions, gopts GlobalOptions, args []string) error { ctx, cancel := context.WithCancel(gopts.ctx) defer cancel() for sn := range FindFilteredSnapshots(ctx, repo, opts.Hosts, opts.Tags, opts.Paths, args) { - changed, err := changeTags(ctx, repo, sn, opts.SetTags, opts.AddTags, opts.RemoveTags) + changed, err := changeTags(ctx, repo, sn, opts.SetTags.Flatten(), opts.AddTags.Flatten(), opts.RemoveTags.Flatten()) if err != nil { Warnf("unable to modify the tags for snapshot ID %q, ignoring: %v\n", sn.ID(), err) continue diff --git a/cmd/restic/integration_test.go b/cmd/restic/integration_test.go index 3d6175318..67dad2ecd 100644 --- a/cmd/restic/integration_test.go +++ b/cmd/restic/integration_test.go @@ -840,7 +840,7 @@ func TestTag(t *testing.T) { "expected original ID to be nil, got %v", newest.Original) originalID := *newest.ID - testRunTag(t, TagOptions{SetTags: []string{"NL"}}, env.gopts) + testRunTag(t, TagOptions{SetTags: restic.TagLists{[]string{"NL"}}}, env.gopts) testRunCheck(t, env.gopts) newest, _ = testRunSnapshots(t, env.gopts) rtest.Assert(t, newest != nil, "expected a new backup, got nil") @@ -850,7 +850,7 @@ func TestTag(t *testing.T) { rtest.Assert(t, *newest.Original == originalID, "expected original ID to be set to the first snapshot id") - testRunTag(t, TagOptions{AddTags: []string{"CH"}}, env.gopts) + testRunTag(t, TagOptions{AddTags: restic.TagLists{[]string{"CH"}}}, env.gopts) testRunCheck(t, env.gopts) newest, _ = testRunSnapshots(t, env.gopts) rtest.Assert(t, newest != nil, "expected a new backup, got nil") @@ -860,7 +860,7 @@ func TestTag(t *testing.T) { rtest.Assert(t, *newest.Original == originalID, "expected original ID to be set to the first snapshot id") - testRunTag(t, TagOptions{RemoveTags: []string{"NL"}}, env.gopts) + testRunTag(t, TagOptions{RemoveTags: restic.TagLists{[]string{"NL"}}}, env.gopts) testRunCheck(t, env.gopts) newest, _ = testRunSnapshots(t, env.gopts) rtest.Assert(t, newest != nil, "expected a new backup, got nil") @@ -870,8 +870,8 @@ func TestTag(t *testing.T) { rtest.Assert(t, *newest.Original == originalID, "expected original ID to be set to the first snapshot id") - testRunTag(t, TagOptions{AddTags: []string{"US", "RU"}}, env.gopts) - testRunTag(t, TagOptions{RemoveTags: []string{"CH", "US", "RU"}}, env.gopts) + testRunTag(t, TagOptions{AddTags: restic.TagLists{[]string{"US", "RU"}}}, env.gopts) + testRunTag(t, TagOptions{RemoveTags: restic.TagLists{[]string{"CH", "US", "RU"}}}, env.gopts) testRunCheck(t, env.gopts) newest, _ = testRunSnapshots(t, env.gopts) rtest.Assert(t, newest != nil, "expected a new backup, got nil") @@ -882,7 +882,7 @@ func TestTag(t *testing.T) { "expected original ID to be set to the first snapshot id") // Check special case of removing all tags. - testRunTag(t, TagOptions{SetTags: []string{""}}, env.gopts) + testRunTag(t, TagOptions{SetTags: restic.TagLists{[]string{""}}}, env.gopts) testRunCheck(t, env.gopts) newest, _ = testRunSnapshots(t, env.gopts) rtest.Assert(t, newest != nil, "expected a new backup, got nil")