/* * Minio Go Library for Amazon S3 Compatible Cloud Storage * Copyright 2015-2017 Minio, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package minio import ( "fmt" "net/http" "net/url" "testing" "time" "github.com/minio/minio-go/pkg/s3utils" ) // Tests signature redacting function used // in filtering on-wire Authorization header. func TestRedactSignature(t *testing.T) { testCases := []struct { authValue string expectedRedactedAuthValue string }{ { authValue: "AWS 1231313:888x000231==", expectedRedactedAuthValue: "AWS **REDACTED**:**REDACTED**", }, { authValue: "AWS4-HMAC-SHA256 Credential=12312313/20170613/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=02131231312313213", expectedRedactedAuthValue: "AWS4-HMAC-SHA256 Credential=**REDACTED**/20170613/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=**REDACTED**", }, } for i, testCase := range testCases { redactedAuthValue := redactSignature(testCase.authValue) if redactedAuthValue != testCase.expectedRedactedAuthValue { t.Errorf("Test %d: Expected %s, got %s", i+1, testCase.expectedRedactedAuthValue, redactedAuthValue) } } } // Tests filter header function by filtering out // some custom header keys. func TestFilterHeader(t *testing.T) { header := http.Header{} header.Set("Content-Type", "binary/octet-stream") header.Set("Content-Encoding", "gzip") newHeader := filterHeader(header, []string{"Content-Type"}) if len(newHeader) > 1 { t.Fatalf("Unexpected size of the returned header, should be 1, got %d", len(newHeader)) } if newHeader.Get("Content-Encoding") != "gzip" { t.Fatalf("Unexpected content-encoding value, expected 'gzip', got %s", newHeader.Get("Content-Encoding")) } } // Tests for 'getEndpointURL(endpoint string, inSecure bool)'. func TestGetEndpointURL(t *testing.T) { testCases := []struct { // Inputs. endPoint string secure bool // Expected result. result string err error // Flag indicating whether the test is expected to pass or not. shouldPass bool }{ {"s3.amazonaws.com", true, "https://s3.amazonaws.com", nil, true}, {"s3.cn-north-1.amazonaws.com.cn", true, "https://s3.cn-north-1.amazonaws.com.cn", nil, true}, {"s3.cn-northwest-1.amazonaws.com.cn", true, "https://s3.cn-northwest-1.amazonaws.com.cn", nil, true}, {"s3.amazonaws.com", false, "http://s3.amazonaws.com", nil, true}, {"s3.cn-north-1.amazonaws.com.cn", false, "http://s3.cn-north-1.amazonaws.com.cn", nil, true}, {"s3.cn-northwest-1.amazonaws.com.cn", false, "http://s3.cn-northwest-1.amazonaws.com.cn", nil, true}, {"192.168.1.1:9000", false, "http://192.168.1.1:9000", nil, true}, {"192.168.1.1:9000", true, "https://192.168.1.1:9000", nil, true}, {"s3.amazonaws.com:443", true, "https://s3.amazonaws.com:443", nil, true}, {"13333.123123.-", true, "", ErrInvalidArgument(fmt.Sprintf("Endpoint: %s does not follow ip address or domain name standards.", "13333.123123.-")), false}, {"13333.123123.-", true, "", ErrInvalidArgument(fmt.Sprintf("Endpoint: %s does not follow ip address or domain name standards.", "13333.123123.-")), false}, {"storage.googleapis.com:4000", true, "", ErrInvalidArgument("Google Cloud Storage endpoint should be 'storage.googleapis.com'."), false}, {"s3.aamzza.-", true, "", ErrInvalidArgument(fmt.Sprintf("Endpoint: %s does not follow ip address or domain name standards.", "s3.aamzza.-")), false}, {"", true, "", ErrInvalidArgument("Endpoint: does not follow ip address or domain name standards."), false}, } for i, testCase := range testCases { result, err := getEndpointURL(testCase.endPoint, testCase.secure) if err != nil && testCase.shouldPass { t.Errorf("Test %d: Expected to pass, but failed with: %s", i+1, err.Error()) } if err == nil && !testCase.shouldPass { t.Errorf("Test %d: Expected to fail with \"%s\", but passed instead", i+1, testCase.err.Error()) } // Failed as expected, but does it fail for the expected reason. if err != nil && !testCase.shouldPass { if err.Error() != testCase.err.Error() { t.Errorf("Test %d: Expected to fail with error \"%s\", but instead failed with error \"%s\" instead", i+1, testCase.err.Error(), err.Error()) } } // Test passes as expected, but the output values are verified for correctness here. if err == nil && testCase.shouldPass { if testCase.result != result.String() { t.Errorf("Test %d: Expected the result Url to be \"%s\", but found \"%s\" instead", i+1, testCase.result, result.String()) } } } } // Tests validate end point validator. func TestIsValidEndpointURL(t *testing.T) { testCases := []struct { url string err error // Flag indicating whether the test is expected to pass or not. shouldPass bool }{ {"", ErrInvalidArgument("Endpoint url cannot be empty."), false}, {"/", nil, true}, {"https://s3.amazonaws.com", nil, true}, {"https://s3.cn-north-1.amazonaws.com.cn", nil, true}, {"https://s3-us-gov-west-1.amazonaws.com", nil, true}, {"https://s3-fips-us-gov-west-1.amazonaws.com", nil, true}, {"https://s3.amazonaws.com/", nil, true}, {"https://storage.googleapis.com/", nil, true}, {"https://z3.amazonaws.com", nil, true}, {"https://mybalancer.us-east-1.elb.amazonaws.com", nil, true}, {"192.168.1.1", ErrInvalidArgument("Endpoint url cannot have fully qualified paths."), false}, {"https://amazon.googleapis.com/", ErrInvalidArgument("Google Cloud Storage endpoint should be 'storage.googleapis.com'."), false}, {"https://storage.googleapis.com/bucket/", ErrInvalidArgument("Endpoint url cannot have fully qualified paths."), false}, {"https://s3.amazonaws.com/bucket/object", ErrInvalidArgument("Endpoint url cannot have fully qualified paths."), false}, } for i, testCase := range testCases { var u url.URL if testCase.url == "" { u = sentinelURL } else { u1, err := url.Parse(testCase.url) if err != nil { t.Errorf("Test %d: Expected to pass, but failed with: %s", i+1, err) } u = *u1 } err := isValidEndpointURL(u) if err != nil && testCase.shouldPass { t.Errorf("Test %d: Expected to pass, but failed with: %s", i+1, err) } if err == nil && !testCase.shouldPass { t.Errorf("Test %d: Expected to fail with \"%s\", but passed instead", i+1, testCase.err) } // Failed as expected, but does it fail for the expected reason. if err != nil && !testCase.shouldPass { if err.Error() != testCase.err.Error() { t.Errorf("Test %d: Expected to fail with error \"%s\", but instead failed with error \"%s\" instead", i+1, testCase.err, err) } } } } func TestDefaultBucketLocation(t *testing.T) { testCases := []struct { endpointURL url.URL regionOverride string expectedLocation string }{ // Region override is set URL is ignored. - Test 1. { endpointURL: url.URL{Host: "s3-fips-us-gov-west-1.amazonaws.com"}, regionOverride: "us-west-1", expectedLocation: "us-west-1", }, // No region override, url based preferenced is honored - Test 2. { endpointURL: url.URL{Host: "s3-fips-us-gov-west-1.amazonaws.com"}, regionOverride: "", expectedLocation: "us-gov-west-1", }, // Region override is honored - Test 3. { endpointURL: url.URL{Host: "s3.amazonaws.com"}, regionOverride: "us-west-1", expectedLocation: "us-west-1", }, // China region should be honored, region override not provided. - Test 4. { endpointURL: url.URL{Host: "s3.cn-north-1.amazonaws.com.cn"}, regionOverride: "", expectedLocation: "cn-north-1", }, // China region should be honored, region override not provided. - Test 5. { endpointURL: url.URL{Host: "s3.cn-northwest-1.amazonaws.com.cn"}, regionOverride: "", expectedLocation: "cn-northwest-1", }, // No region provided, no standard region strings provided as well. - Test 6. { endpointURL: url.URL{Host: "s3.amazonaws.com"}, regionOverride: "", expectedLocation: "us-east-1", }, } for i, testCase := range testCases { retLocation := getDefaultLocation(testCase.endpointURL, testCase.regionOverride) if testCase.expectedLocation != retLocation { t.Errorf("Test %d: Expected location %s, got %s", i+1, testCase.expectedLocation, retLocation) } } } // Tests validate the expiry time validator. func TestIsValidExpiry(t *testing.T) { testCases := []struct { // Input. duration time.Duration // Expected result. err error // Flag to indicate whether the test should pass. shouldPass bool }{ {100 * time.Millisecond, ErrInvalidArgument("Expires cannot be lesser than 1 second."), false}, {604801 * time.Second, ErrInvalidArgument("Expires cannot be greater than 7 days."), false}, {0 * time.Second, ErrInvalidArgument("Expires cannot be lesser than 1 second."), false}, {1 * time.Second, nil, true}, {10000 * time.Second, nil, true}, {999 * time.Second, nil, true}, } for i, testCase := range testCases { err := isValidExpiry(testCase.duration) if err != nil && testCase.shouldPass { t.Errorf("Test %d: Expected to pass, but failed with: %s", i+1, err.Error()) } if err == nil && !testCase.shouldPass { t.Errorf("Test %d: Expected to fail with \"%s\", but passed instead", i+1, testCase.err.Error()) } // Failed as expected, but does it fail for the expected reason. if err != nil && !testCase.shouldPass { if err.Error() != testCase.err.Error() { t.Errorf("Test %d: Expected to fail with error \"%s\", but instead failed with error \"%s\" instead", i+1, testCase.err.Error(), err.Error()) } } } } // Tests validate the bucket name validator. func TestIsValidBucketName(t *testing.T) { testCases := []struct { // Input. bucketName string // Expected result. err error // Flag to indicate whether test should Pass. shouldPass bool }{ {".mybucket", ErrInvalidBucketName("Bucket name contains invalid characters"), false}, {"mybucket.", ErrInvalidBucketName("Bucket name contains invalid characters"), false}, {"mybucket-", ErrInvalidBucketName("Bucket name contains invalid characters"), false}, {"my", ErrInvalidBucketName("Bucket name cannot be smaller than 3 characters"), false}, {"", ErrInvalidBucketName("Bucket name cannot be empty"), false}, {"my..bucket", ErrInvalidBucketName("Bucket name contains invalid characters"), false}, {"my.bucket.com", nil, true}, {"my-bucket", nil, true}, {"123my-bucket", nil, true}, } for i, testCase := range testCases { err := s3utils.CheckValidBucketName(testCase.bucketName) if err != nil && testCase.shouldPass { t.Errorf("Test %d: Expected to pass, but failed with: %s", i+1, err.Error()) } if err == nil && !testCase.shouldPass { t.Errorf("Test %d: Expected to fail with \"%s\", but passed instead", i+1, testCase.err.Error()) } // Failed as expected, but does it fail for the expected reason. if err != nil && !testCase.shouldPass { if err.Error() != testCase.err.Error() { t.Errorf("Test %d: Expected to fail with error \"%s\", but instead failed with error \"%s\" instead", i+1, testCase.err.Error(), err.Error()) } } } } // Tests if header is standard supported header func TestIsStandardHeader(t *testing.T) { testCases := []struct { // Input. header string // Expected result. expectedValue bool }{ {"content-encoding", true}, {"content-type", true}, {"cache-control", true}, {"content-disposition", true}, {"content-language", true}, {"random-header", false}, } for i, testCase := range testCases { actual := isStandardHeader(testCase.header) if actual != testCase.expectedValue { t.Errorf("Test %d: Expected to pass, but failed", i+1) } } } // Tests if header is server encryption header func TestIsSSEHeader(t *testing.T) { testCases := []struct { // Input. header string // Expected result. expectedValue bool }{ {"x-amz-server-side-encryption", true}, {"x-amz-server-side-encryption-aws-kms-key-id", true}, {"x-amz-server-side-encryption-context", true}, {"x-amz-server-side-encryption-customer-algorithm", true}, {"x-amz-server-side-encryption-customer-key", true}, {"x-amz-server-side-encryption-customer-key-MD5", true}, {"random-header", false}, } for i, testCase := range testCases { actual := isSSEHeader(testCase.header) if actual != testCase.expectedValue { t.Errorf("Test %d: Expected to pass, but failed", i+1) } } } // Tests if header is x-amz-meta or x-amz-acl func TestIsAmzHeader(t *testing.T) { testCases := []struct { // Input. header string // Expected result. expectedValue bool }{ {"x-amz-iv", false}, {"x-amz-key", false}, {"x-amz-matdesc", false}, {"x-amz-meta-x-amz-iv", true}, {"x-amz-meta-x-amz-key", true}, {"x-amz-meta-x-amz-matdesc", true}, {"x-amz-acl", true}, {"random-header", false}, } for i, testCase := range testCases { actual := isAmzHeader(testCase.header) if actual != testCase.expectedValue { t.Errorf("Test %d: Expected to pass, but failed", i+1) } } }