restic/internal/backend
Michael Pratt fa0be82da8 gs: allow backend creation without storage.buckets.get
If the service account used with restic does not have the
storage.buckets.get permission (in the "Storage Admin" role), Create
cannot use Get to determine if the bucket is accessible.

Rather than always trying to create the bucket on Get error, gracefully
fall back to assuming the bucket is accessible. If it is, restic init
will complete successfully. If it is not, it will fail on a later call.

Here is what init looks like now in different cases.

Service account without "Storage Admin":

Bucket exists and is accessible (this is the case that didn't work
before):

$ ./restic init -r gs:this-bucket-does-exist:/
enter password for new backend:
enter password again:
created restic backend c02e2edb67 at gs:this-bucket-does-exist:/

Please note that knowledge of your password is required to access
the repository. Losing your password means that your data is
irrecoverably lost.

Bucket exists but is not accessible:

$ ./restic init -r gs:this-bucket-does-exist:/
enter password for new backend:
enter password again:
create key in backend at gs:this-bucket-does-exist:/ failed:
service.Objects.Insert: googleapi: Error 403:
my-service-account@myproject.iam.gserviceaccount.com does not have
storage.objects.create access to object this-bucket-exists/keys/0fa714e695c8ecd58cb467cdeb04d36f3b710f883496a90f23cae0315daf0b93., forbidden

Bucket does not exist:

$ ./restic init -r gs:this-bucket-does-not-exist:/
create backend at gs:this-bucket-does-not-exist:/ failed:
service.Buckets.Insert: googleapi: Error 403:
my-service-account@myproject.iam.gserviceaccount.com does not have storage.buckets.create access to bucket this-bucket-does-not-exist., forbidden

Service account with "Storage Admin":

Bucket exists and is accessible: Same

Bucket exists but is not accessible: Same. Previously this would fail
when Create tried to create the bucket. Now it fails when trying to
create the keys.

Bucket does not exist:

$ ./restic init -r gs:this-bucket-does-not-exist:/
enter password for new backend:
enter password again:
created restic backend c3c48b481d at gs:this-bucket-does-not-exist:/

Please note that knowledge of your password is required to access
the repository. Losing your password means that your data is
irrecoverably lost.
2017-09-25 22:25:51 -07:00
..
azure backend: Make pagination for List configurable 2017-09-18 12:01:54 +02:00
b2 b2: Add pagination for List() 2017-09-18 12:13:35 +02:00
gs gs: allow backend creation without storage.buckets.get 2017-09-25 22:25:51 -07:00
local local/sftp: Remove unneeded stat() call 2017-09-21 21:47:03 +02:00
location Merge pull request #1149 from restic/azure-support 2017-08-09 21:30:35 +02:00
mem Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
rest Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
s3 Implement Size() and Len() to know the optimal size. 2017-09-22 12:09:17 -07:00
sftp sftp: Allow password entry 2017-09-23 11:43:33 +02:00
swift Ignore "not exist" errors for swift backend tests 2017-09-16 13:59:55 +02:00
test backend: Improve TestList 2017-09-18 13:18:42 +02:00
testdata Moves files 2017-07-23 14:19:13 +02:00
doc.go Moves files 2017-07-23 14:19:13 +02:00
http_transport.go Run goimports 2017-07-23 14:21:03 +02:00
layout.go Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
layout_default.go Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
layout_rest.go Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
layout_s3legacy.go Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
layout_test.go Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
paths.go Moves files 2017-07-23 14:19:13 +02:00
semaphore.go Run goimports 2017-07-23 14:21:03 +02:00
utils.go Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
utils_test.go Move restic package to internal/restic 2017-07-24 17:43:32 +02:00