mirror of
https://github.com/yuzu-emu/yuzu.git
synced 2024-08-22 06:53:21 +02:00
dyncom: Read-after-write in SMLA
In the case when RD === RN, RD was updated before AddOverflow was called to check for an overflow, resulting in an incorrect state of the Q flag.
This commit is contained in:
parent
7b4dcacbb2
commit
15b2eec4bd
@ -2820,10 +2820,12 @@ unsigned InterpreterMainLoop(ARMul_State* cpu) {
|
||||
operand2 = (BIT(RS, 15)) ? (BITS(RS, 0, 15) | 0xffff0000) : BITS(RS, 0, 15);
|
||||
else
|
||||
operand2 = (BIT(RS, 31)) ? (BITS(RS, 16, 31) | 0xffff0000) : BITS(RS, 16, 31);
|
||||
RD = operand1 * operand2 + RN;
|
||||
|
||||
if (AddOverflow(operand1 * operand2, RN, RD))
|
||||
u32 product = operand1 * operand2;
|
||||
u32 result = product + RN;
|
||||
if (AddOverflow(product, RN, result))
|
||||
cpu->Cpsr |= (1 << 27);
|
||||
RD = result;
|
||||
}
|
||||
cpu->Reg[15] += cpu->GetInstructionSize();
|
||||
INC_PC(sizeof(smla_inst));
|
||||
|
Loading…
Reference in New Issue
Block a user