From a71346cd7c5d3959ca3b07e5b45f4d2c8a9144e9 Mon Sep 17 00:00:00 2001 From: bunnei Date: Sun, 29 Apr 2018 13:13:13 -0400 Subject: [PATCH 1/5] gl_shader_decompiler: Implement MOV_C. --- src/video_core/renderer_opengl/gl_shader_decompiler.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp index 27190cc450..6d5b7a99c7 100644 --- a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp +++ b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp @@ -664,6 +664,11 @@ private: } switch (opcode->GetId()) { + case OpCode::Id::MOV_C: { + regs.SetRegisterToFloat(instr.gpr0, 0, op_b, 1, 1); + break; + } + case OpCode::Id::MOV32_IMM: { // mov32i doesn't have abs or neg bits. regs.SetRegisterToFloat(instr.gpr0, 0, GetImmediate32(instr), 1, 1); From c7ce472eeb6c6ff8892ee0314910031bc807c8c7 Mon Sep 17 00:00:00 2001 From: bunnei Date: Sun, 29 Apr 2018 13:49:16 -0400 Subject: [PATCH 2/5] shader_bytecode: Add decoding for FMNMX instruction. --- src/video_core/engines/shader_bytecode.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/video_core/engines/shader_bytecode.h b/src/video_core/engines/shader_bytecode.h index f20c2cd419..e1ceec268b 100644 --- a/src/video_core/engines/shader_bytecode.h +++ b/src/video_core/engines/shader_bytecode.h @@ -310,6 +310,7 @@ public: SHR_C, SHR_R, SHR_IMM, + FMNMX, FSETP_C, // Set Predicate FSETP_R, FSETP_IMM, @@ -460,6 +461,7 @@ private: INST("0100110000101---", Id::SHR_C, Type::Arithmetic, "SHR_C"), INST("0101110000101---", Id::SHR_R, Type::Arithmetic, "SHR_R"), INST("0011100-00101---", Id::SHR_IMM, Type::Arithmetic, "SHR_IMM"), + INST("0101110001100---", Id::FMNMX, Type::Arithmetic, "FMNMX"), INST("0100110011100---", Id::I2I_C, Type::Conversion, "I2I_C"), INST("0101110011100---", Id::I2I_R, Type::Conversion, "I2I_R"), INST("01110001-1000---", Id::I2I_IMM, Type::Conversion, "I2I_IMM"), From 316327f48730a40cab2a497dcb2d7ccb5a716bff Mon Sep 17 00:00:00 2001 From: bunnei Date: Sun, 29 Apr 2018 13:50:02 -0400 Subject: [PATCH 3/5] maxwell_to_gl: Implement type SignedNorm, Size_8_8_8_8. --- src/video_core/renderer_opengl/maxwell_to_gl.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/video_core/renderer_opengl/maxwell_to_gl.h b/src/video_core/renderer_opengl/maxwell_to_gl.h index a49265b38f..a630610d80 100644 --- a/src/video_core/renderer_opengl/maxwell_to_gl.h +++ b/src/video_core/renderer_opengl/maxwell_to_gl.h @@ -36,6 +36,18 @@ inline GLenum VertexType(Maxwell::VertexAttribute attrib) { return {}; } + case Maxwell::VertexAttribute::Type::SignedNorm: { + + switch (attrib.size) { + case Maxwell::VertexAttribute::Size::Size_8_8_8_8: + return GL_BYTE; + } + + NGLOG_CRITICAL(Render_OpenGL, "Unimplemented vertex size={}", attrib.SizeString()); + UNREACHABLE(); + return {}; + } + case Maxwell::VertexAttribute::Type::Float: return GL_FLOAT; } From 08b8fcbe6ddd3305c7e422e5a64c3112af5bbeb9 Mon Sep 17 00:00:00 2001 From: bunnei Date: Sun, 29 Apr 2018 13:50:52 -0400 Subject: [PATCH 4/5] gl_shader_decompiler: Implement MOV_R. --- src/video_core/renderer_opengl/gl_shader_decompiler.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp index 6d5b7a99c7..539aa87f90 100644 --- a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp +++ b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp @@ -664,7 +664,8 @@ private: } switch (opcode->GetId()) { - case OpCode::Id::MOV_C: { + case OpCode::Id::MOV_C: + case OpCode::Id::MOV_R: { regs.SetRegisterToFloat(instr.gpr0, 0, op_b, 1, 1); break; } From f41eb95e13b88a55572887c3b5e4890bcb84edb2 Mon Sep 17 00:00:00 2001 From: bunnei Date: Sun, 29 Apr 2018 16:23:31 -0400 Subject: [PATCH 5/5] maxwell_3d: Reset vertex counts after drawing. --- src/video_core/engines/maxwell_3d.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/video_core/engines/maxwell_3d.cpp b/src/video_core/engines/maxwell_3d.cpp index 835e5fe78e..23e70cd8ad 100644 --- a/src/video_core/engines/maxwell_3d.cpp +++ b/src/video_core/engines/maxwell_3d.cpp @@ -208,6 +208,16 @@ void Maxwell3D::DrawArrays() { const bool is_indexed{regs.index_array.count && !regs.vertex_buffer.count}; VideoCore::g_renderer->Rasterizer()->AccelerateDrawBatch(is_indexed); + + // TODO(bunnei): Below, we reset vertex count so that we can use these registers to determine if + // the game is trying to draw indexed or direct mode. This needs to be verified on HW still - + // it's possible that it is incorrect and that there is some other register used to specify the + // drawing mode. + if (is_indexed) { + regs.index_array.count = 0; + } else { + regs.vertex_buffer.count = 0; + } } void Maxwell3D::ProcessCBBind(Regs::ShaderStage stage) {