mirror of
https://github.com/yuzu-emu/yuzu.git
synced 2024-08-22 01:43:22 +02:00
texture_cache/util: Avoid relaxed image views on different bytes per pixel
Avoids API usage errors on UE4 titles leading to crashes.
This commit is contained in:
parent
8b5655a98e
commit
3d89398b84
@ -1087,7 +1087,15 @@ std::optional<SubresourceBase> FindSubresource(const ImageInfo& candidate, const
|
|||||||
return std::nullopt;
|
return std::nullopt;
|
||||||
}
|
}
|
||||||
const ImageInfo& existing = image.info;
|
const ImageInfo& existing = image.info;
|
||||||
if (False(options & RelaxedOptions::Format)) {
|
if (True(options & RelaxedOptions::Format)) {
|
||||||
|
// Format checking is relaxed, but we still have to check for matching bytes per block.
|
||||||
|
// This avoids creating a view for blits on UE4 titles where formats with different bytes
|
||||||
|
// per block are aliased.
|
||||||
|
if (BytesPerBlock(existing.format) != BytesPerBlock(candidate.format)) {
|
||||||
|
return std::nullopt;
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
// Format comaptibility is not relaxed, ensure we are creating a view on a compatible format
|
||||||
if (!IsViewCompatible(existing.format, candidate.format, broken_views, native_bgr)) {
|
if (!IsViewCompatible(existing.format, candidate.format, broken_views, native_bgr)) {
|
||||||
return std::nullopt;
|
return std::nullopt;
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user