From ca8ab1bc3b4ac200243712998b1d04c557912caa Mon Sep 17 00:00:00 2001 From: heapo Date: Wed, 5 Dec 2018 10:30:50 -0800 Subject: [PATCH] Call shrink_to_fit after page-table vector resizing to cause crt to actually lower vector capacity. For 36-bit titles saves 800MB of commit. --- src/core/memory.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/core/memory.cpp b/src/core/memory.cpp index 70abd856a8..41fd2a6a01 100644 --- a/src/core/memory.cpp +++ b/src/core/memory.cpp @@ -53,6 +53,14 @@ void PageTable::Resize(std::size_t address_space_width_in_bits) { pointers.resize(num_page_table_entries); attributes.resize(num_page_table_entries); + + // The default is a 39-bit address space, which causes an initial 1GB allocation size. If the + // vector size is subsequently decreased (via resize), the vector might not automatically + // actually reallocate/resize its underlying allocation, which wastes up to ~800 MB for + // 36-bit titles. Call shrink_to_fit to reduce capacity to what's actually in use. + + pointers.shrink_to_fit(); + attributes.shrink_to_fit(); } static void MapPages(PageTable& page_table, VAddr base, u64 size, u8* memory, PageType type) {