mirror of
https://github.com/yuzu-emu/yuzu.git
synced 2024-08-24 15:07:20 +02:00
Fix two GCC 11 warnings: Unneeded copies.
std::move created an unneeded copy. iterating without reference also created copies.
This commit is contained in:
parent
420b1f89d3
commit
5a8cd1b118
@ -258,7 +258,7 @@ struct KernelCore::Impl {
|
|||||||
KAutoObject::Create(thread.get());
|
KAutoObject::Create(thread.get());
|
||||||
ASSERT(KThread::InitializeDummyThread(thread.get()).IsSuccess());
|
ASSERT(KThread::InitializeDummyThread(thread.get()).IsSuccess());
|
||||||
thread->SetName(fmt::format("DummyThread:{}", GetHostThreadId()));
|
thread->SetName(fmt::format("DummyThread:{}", GetHostThreadId()));
|
||||||
return std::move(thread);
|
return thread;
|
||||||
};
|
};
|
||||||
|
|
||||||
thread_local auto thread = make_thread();
|
thread_local auto thread = make_thread();
|
||||||
|
@ -596,7 +596,7 @@ void BufferCache<P>::PopAsyncFlushes() {
|
|||||||
runtime.CopyBuffer(download_staging.buffer, slot_buffers[buffer_id], copies);
|
runtime.CopyBuffer(download_staging.buffer, slot_buffers[buffer_id], copies);
|
||||||
}
|
}
|
||||||
runtime.Finish();
|
runtime.Finish();
|
||||||
for (const auto [copy, buffer_id] : downloads) {
|
for (const auto& [copy, buffer_id] : downloads) {
|
||||||
const Buffer& buffer = slot_buffers[buffer_id];
|
const Buffer& buffer = slot_buffers[buffer_id];
|
||||||
const VAddr cpu_addr = buffer.CpuAddr() + copy.src_offset;
|
const VAddr cpu_addr = buffer.CpuAddr() + copy.src_offset;
|
||||||
// Undo the modified offset
|
// Undo the modified offset
|
||||||
@ -606,7 +606,7 @@ void BufferCache<P>::PopAsyncFlushes() {
|
|||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
const std::span<u8> immediate_buffer = ImmediateBuffer(largest_copy);
|
const std::span<u8> immediate_buffer = ImmediateBuffer(largest_copy);
|
||||||
for (const auto [copy, buffer_id] : downloads) {
|
for (const auto& [copy, buffer_id] : downloads) {
|
||||||
Buffer& buffer = slot_buffers[buffer_id];
|
Buffer& buffer = slot_buffers[buffer_id];
|
||||||
buffer.ImmediateDownload(copy.src_offset, immediate_buffer.subspan(0, copy.size));
|
buffer.ImmediateDownload(copy.src_offset, immediate_buffer.subspan(0, copy.size));
|
||||||
const VAddr cpu_addr = buffer.CpuAddr() + copy.src_offset;
|
const VAddr cpu_addr = buffer.CpuAddr() + copy.src_offset;
|
||||||
|
Loading…
Reference in New Issue
Block a user