rdelaage/yuzu
1
0
Fork 0
mirror of https://github.com/yuzu-emu/yuzu.git synced 2024-08-21 14:13:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

romfs_factory: Read from all locations with StorageId None

Browse Source 
Previous behavior was to assert. Seems to mirror expected game behavior.
This commit is contained in:
Zach Hilman 2018-09-26 22:15:51 -04:00
parent 32fc31fb13
commit aa0c82e405
1 changed files with 25 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
src/core/file_sys/romfs_factory.cpp
View File

@ -39,36 +39,35 @@ ResultVal<VirtualFile> RomFSFactory::OpenCurrentProcess() {
} }
ResultVal<VirtualFile> RomFSFactory::Open(u64 title_id, StorageId storage, ContentRecordType type) { ResultVal<VirtualFile> RomFSFactory::Open(u64 title_id, StorageId storage, ContentRecordType type) {
std::shared_ptr<NCA> res;
switch (storage) { switch (storage) {
case StorageId::NandSystem: { case StorageId::None:
const auto res = Service::FileSystem::GetSystemNANDContents()->GetEntry(title_id, type); res = Service::FileSystem::GetUnionContents()->GetEntry(title_id, type);
if (res == nullptr) { break;
// TODO(DarkLordZach): Find the right error code to use here case StorageId::NandSystem:
return ResultCode(-1); res = Service::FileSystem::GetSystemNANDContents()->GetEntry(title_id, type);
} break;
const auto romfs = res->GetRomFS(); case StorageId::NandUser:
if (romfs == nullptr) { res = Service::FileSystem::GetUserNANDContents()->GetEntry(title_id, type);
// TODO(DarkLordZach): Find the right error code to use here break;
return ResultCode(-1); case StorageId::SdCard:
} res = Service::FileSystem::GetSDMCContents()->GetEntry(title_id, type);
return MakeResult<VirtualFile>(romfs); break;
}
case StorageId::NandUser: {
const auto res = Service::FileSystem::GetUserNANDContents()->GetEntry(title_id, type);
if (res == nullptr) {
// TODO(DarkLordZach): Find the right error code to use here
return ResultCode(-1);
}
const auto romfs = res->GetRomFS();
if (romfs == nullptr) {
// TODO(DarkLordZach): Find the right error code to use here
return ResultCode(-1);
}
return MakeResult<VirtualFile>(romfs);
}
default: default:
UNIMPLEMENTED_MSG("Unimplemented storage_id={:02X}", static_cast<u8>(storage)); UNIMPLEMENTED_MSG("Unimplemented storage_id={:02X}", static_cast<u8>(storage));
} }
if (res == nullptr) {
// TODO(DarkLordZach): Find the right error code to use here
return ResultCode(-1);
}
const auto romfs = res->GetRomFS();
if (romfs == nullptr) {
// TODO(DarkLordZach): Find the right error code to use here
return ResultCode(-1);
}
return MakeResult<VirtualFile>(romfs);
} }
} // namespace FileSys } // namespace FileSys