From c13fbe6a41a8e496e6b7de38a15669344e9cab7a Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 5 Apr 2019 20:30:46 -0400 Subject: [PATCH] video_core/memory_manager: Make Read() a const qualified member function Given this doesn't actually alter internal state, this can be made a const member function. --- src/video_core/memory_manager.cpp | 10 +++++----- src/video_core/memory_manager.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/video_core/memory_manager.cpp b/src/video_core/memory_manager.cpp index 2b3651f206..8417324ffd 100644 --- a/src/video_core/memory_manager.cpp +++ b/src/video_core/memory_manager.cpp @@ -114,7 +114,7 @@ std::optional MemoryManager::GpuToCpuAddress(GPUVAddr addr) const { } template -T MemoryManager::Read(GPUVAddr addr) { +T MemoryManager::Read(GPUVAddr addr) const { if (!IsAddressValid(addr)) { return {}; } @@ -166,10 +166,10 @@ void MemoryManager::Write(GPUVAddr addr, T data) { } } -template u8 MemoryManager::Read(GPUVAddr addr); -template u16 MemoryManager::Read(GPUVAddr addr); -template u32 MemoryManager::Read(GPUVAddr addr); -template u64 MemoryManager::Read(GPUVAddr addr); +template u8 MemoryManager::Read(GPUVAddr addr) const; +template u16 MemoryManager::Read(GPUVAddr addr) const; +template u32 MemoryManager::Read(GPUVAddr addr) const; +template u64 MemoryManager::Read(GPUVAddr addr) const; template void MemoryManager::Write(GPUVAddr addr, u8 data); template void MemoryManager::Write(GPUVAddr addr, u16 data); template void MemoryManager::Write(GPUVAddr addr, u32 data); diff --git a/src/video_core/memory_manager.h b/src/video_core/memory_manager.h index 273d538b81..178e2f6552 100644 --- a/src/video_core/memory_manager.h +++ b/src/video_core/memory_manager.h @@ -53,7 +53,7 @@ public: std::optional GpuToCpuAddress(GPUVAddr addr) const; template - T Read(GPUVAddr addr); + T Read(GPUVAddr addr) const; template void Write(GPUVAddr addr, T data);