From d9b1199ffb7670248a02acce7e8216f5a577de38 Mon Sep 17 00:00:00 2001 From: Wunkolo Date: Wed, 9 Mar 2022 19:34:39 -0800 Subject: [PATCH] cpu_detect: Revert `__cpuid{ex}` array-type argument Restores compatibility with MSVC's `__cpuid` intrinsic. --- src/common/x64/cpu_detect.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/common/x64/cpu_detect.cpp b/src/common/x64/cpu_detect.cpp index a95dc15a3d..99d87f586a 100644 --- a/src/common/x64/cpu_detect.cpp +++ b/src/common/x64/cpu_detect.cpp @@ -21,7 +21,7 @@ // clang-format on #endif -static inline void __cpuidex(const std::span info, u32 function_id, u32 subfunction_id) { +static inline void __cpuidex(int info[4], u32 function_id, u32 subfunction_id) { #if defined(__DragonFly__) || defined(__FreeBSD__) // Despite the name, this is just do_cpuid() with ECX as second input. cpuid_count((u_int)function_id, (u_int)subfunction_id, (u_int*)info); @@ -34,7 +34,7 @@ static inline void __cpuidex(const std::span info, u32 function_id, u32 #endif } -static inline void __cpuid(const std::span info, u32 function_id) { +static inline void __cpuid(int info[4], u32 function_id) { return __cpuidex(info, function_id, 0); } @@ -67,7 +67,7 @@ static CPUCaps Detect() { // Assumes the CPU supports the CPUID instruction. Those that don't would likely not support // yuzu at all anyway - std::array cpu_id; + int cpu_id[4]; // Detect CPU's CPUID capabilities and grab manufacturer string __cpuid(cpu_id, 0x00000000); @@ -128,11 +128,11 @@ static CPUCaps Detect() { if (max_ex_fn >= 0x80000004) { // Extract CPU model string __cpuid(cpu_id, 0x80000002); - std::memcpy(caps.cpu_string, cpu_id.data(), sizeof(cpu_id)); + std::memcpy(caps.cpu_string, cpu_id, sizeof(cpu_id)); __cpuid(cpu_id, 0x80000003); - std::memcpy(caps.cpu_string + 16, cpu_id.data(), sizeof(cpu_id)); + std::memcpy(caps.cpu_string + 16, cpu_id, sizeof(cpu_id)); __cpuid(cpu_id, 0x80000004); - std::memcpy(caps.cpu_string + 32, cpu_id.data(), sizeof(cpu_id)); + std::memcpy(caps.cpu_string + 32, cpu_id, sizeof(cpu_id)); } if (max_ex_fn >= 0x80000001) {