Merge pull request #1440 from lioncash/array

ui_settings: Place definition of the theme array within the cpp file
This commit is contained in:
bunnei 2018-10-05 22:54:01 -04:00 committed by GitHub
commit e6ee31a8e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 5 deletions

View File

@ -13,7 +13,7 @@ ConfigureGeneral::ConfigureGeneral(QWidget* parent)
ui->setupUi(this);
for (auto theme : UISettings::themes) {
for (const auto& theme : UISettings::themes) {
ui->theme_combobox->addItem(theme.first, theme.second);
}

View File

@ -6,5 +6,11 @@
namespace UISettings {
const Themes themes{{
{"Default", "default"},
{"Dark", "qdarkstyle"},
}};
Values values = {};
}
} // namespace UISettings

View File

@ -15,9 +15,8 @@ namespace UISettings {
using ContextualShortcut = std::pair<QString, int>;
using Shortcut = std::pair<QString, ContextualShortcut>;
static const std::array<std::pair<QString, QString>, 2> themes = {
{std::make_pair(QString("Default"), QString("default")),
std::make_pair(QString("Dark"), QString("qdarkstyle"))}};
using Themes = std::array<std::pair<const char*, const char*>, 2>;
extern const Themes themes;
struct Values {
QByteArray geometry;