From 9ac176d5a32c29dbf84208e7142fb87b012496e5 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 5 Mar 2019 16:55:53 -0500 Subject: [PATCH] hle/service/audio/audout_u: Correct lack of return in failure case of AppendAudioOutBufferImpl() Previously we were overwriting the error case with a success code further down (which is definitely not what we should be doing here). --- src/core/hle/service/audio/audout_u.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/hle/service/audio/audout_u.cpp b/src/core/hle/service/audio/audout_u.cpp index 1c04d21cf0..bbe8134900 100644 --- a/src/core/hle/service/audio/audout_u.cpp +++ b/src/core/hle/service/audio/audout_u.cpp @@ -138,6 +138,7 @@ private: if (!audio_core.QueueBuffer(stream, tag, std::move(samples))) { IPC::ResponseBuilder rb{ctx, 2}; rb.Push(ERR_BUFFER_COUNT_EXCEEDED); + return; } IPC::ResponseBuilder rb{ctx, 2};