From b8b87ec01f134daaf5a8a2df30846e9dba786cfc Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 17 Jan 2019 11:35:55 -0500 Subject: [PATCH 1/2] yuzu/configuration/configure_web: Use an ellipsis with 'Verifying' text It's a common UI pattern to use an ellipsis to indicate an ongoing action, rather than just specifying the word by itself. --- src/yuzu/configuration/configure_web.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/yuzu/configuration/configure_web.cpp b/src/yuzu/configuration/configure_web.cpp index 3c2ccb76f8..7841413ee2 100644 --- a/src/yuzu/configuration/configure_web.cpp +++ b/src/yuzu/configuration/configure_web.cpp @@ -89,7 +89,7 @@ void ConfigureWeb::OnLoginChanged() { void ConfigureWeb::VerifyLogin() { ui->button_verify_login->setDisabled(true); - ui->button_verify_login->setText(tr("Verifying")); + ui->button_verify_login->setText(tr("Verifying...")); verify_watcher.setFuture( QtConcurrent::run([this, username = ui->edit_username->text().toStdString(), token = ui->edit_token->text().toStdString()]() { From 549164d425e42ebbf7ba9c79cb533dd6fc215f8a Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 17 Jan 2019 11:39:46 -0500 Subject: [PATCH 2/2] yuzu/configuration/configure_web: Remove an unused lambda capture 'this' isn't actually used within the lambda, since what we need from the class is already assigned within the capture section of the lambda. --- src/yuzu/configuration/configure_web.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/yuzu/configuration/configure_web.cpp b/src/yuzu/configuration/configure_web.cpp index 7841413ee2..18566d0289 100644 --- a/src/yuzu/configuration/configure_web.cpp +++ b/src/yuzu/configuration/configure_web.cpp @@ -90,11 +90,10 @@ void ConfigureWeb::OnLoginChanged() { void ConfigureWeb::VerifyLogin() { ui->button_verify_login->setDisabled(true); ui->button_verify_login->setText(tr("Verifying...")); - verify_watcher.setFuture( - QtConcurrent::run([this, username = ui->edit_username->text().toStdString(), - token = ui->edit_token->text().toStdString()]() { - return Core::VerifyLogin(username, token); - })); + verify_watcher.setFuture(QtConcurrent::run([username = ui->edit_username->text().toStdString(), + token = ui->edit_token->text().toStdString()] { + return Core::VerifyLogin(username, token); + })); } void ConfigureWeb::OnLoginVerified() {