rdelaage
/
gmid
mirror of https://github.com/omar-polo/gmid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

sync imsg

This commit is contained in:
Omar Polo 2024-01-07 18:27:41 +00:00
parent b8537c1c54
commit 12eb29d878
3 changed files with 461 additions and 114 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

265
compat/imsg-buffer.c
View File

@ -1,6 +1,7 @@
/* $OpenBSD: imsg-buffer.c,v 1.16 2023/06/19 17:19:50 claudio Exp $ */ /* $OpenBSD: imsg-buffer.c,v 1.18 2023/12/12 15:47:41 claudio Exp $ */
/* /*
* Copyright (c) 2023 Claudio Jeker <claudio@openbsd.org>
* Copyright (c) 2003, 2004 Henning Brauer <henning@openbsd.org> * Copyright (c) 2003, 2004 Henning Brauer <henning@openbsd.org>
* *
* Permission to use, copy, modify, and distribute this software for any * Permission to use, copy, modify, and distribute this software for any
@ -24,6 +25,8 @@
#include <limits.h> #include <limits.h>
#include <errno.h> #include <errno.h>
#include <endian.h>
#include <stdint.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <unistd.h> #include <unistd.h>
@ -61,7 +64,7 @@ ibuf_dynamic(size_t len, size_t max)
{ {
struct ibuf *buf; struct ibuf *buf;
if (max < len) { if (max == 0 || max < len) {
errno = EINVAL; errno = EINVAL;
return (NULL); return (NULL);
} }
@ -106,7 +109,7 @@ ibuf_reserve(struct ibuf *buf, size_t len)
{ {
void *b; void *b;
if (len > SIZE_MAX - buf->wpos) { if (len > SIZE_MAX - buf->wpos || buf->max == 0) {
errno = ERANGE; errno = ERANGE;
return (NULL); return (NULL);
} }
@ -117,7 +120,6 @@ ibuf_reserve(struct ibuf *buf, size_t len)
b = buf->buf + buf->wpos; b = buf->buf + buf->wpos;
buf->wpos += len; buf->wpos += len;
memset(b, 0, len);
return (b); return (b);
} }
@ -133,10 +135,17 @@ ibuf_add(struct ibuf *buf, const void *data, size_t len)
return (0); return (0);
} }
int
ibuf_add_ibuf(struct ibuf *buf, const struct ibuf *from)
{
return ibuf_add(buf, ibuf_data(from), ibuf_size(from));
}
/* remove after tree is converted */
int int
ibuf_add_buf(struct ibuf *buf, const struct ibuf *from) ibuf_add_buf(struct ibuf *buf, const struct ibuf *from)
{ {
return ibuf_add(buf, from->buf, from->wpos); return ibuf_add_ibuf(buf, from);
} }
int int
@ -185,6 +194,38 @@ ibuf_add_n64(struct ibuf *buf, uint64_t value)
return ibuf_add(buf, &value, sizeof(value)); return ibuf_add(buf, &value, sizeof(value));
} }
int
ibuf_add_h16(struct ibuf *buf, uint64_t value)
{
uint16_t v;
if (value > UINT16_MAX) {
errno = EINVAL;
return (-1);
}
v = value;
return ibuf_add(buf, &v, sizeof(v));
}
int
ibuf_add_h32(struct ibuf *buf, uint64_t value)
{
uint32_t v;
if (value > UINT32_MAX) {
errno = EINVAL;
return (-1);
}
v = value;
return ibuf_add(buf, &v, sizeof(v));
}
int
ibuf_add_h64(struct ibuf *buf, uint64_t value)
{
return ibuf_add(buf, &value, sizeof(value));
}
int int
ibuf_add_zero(struct ibuf *buf, size_t len) ibuf_add_zero(struct ibuf *buf, size_t len)
{ {
@ -192,19 +233,21 @@ ibuf_add_zero(struct ibuf *buf, size_t len)
if ((b = ibuf_reserve(buf, len)) == NULL) if ((b = ibuf_reserve(buf, len)) == NULL)
return (-1); return (-1);
memset(b, 0, len);
return (0); return (0);
} }
void * void *
ibuf_seek(struct ibuf *buf, size_t pos, size_t len) ibuf_seek(struct ibuf *buf, size_t pos, size_t len)
{ {
/* only allowed to seek in already written parts */ /* only allow seeking between rpos and wpos */
if (len > SIZE_MAX - pos || pos + len > buf->wpos) { if (ibuf_size(buf) < pos || SIZE_MAX - pos < len ||
ibuf_size(buf) < pos + len) {
errno = ERANGE; errno = ERANGE;
return (NULL); return (NULL);
} }
return (buf->buf + pos); return (buf->buf + buf->rpos + pos);
} }
int int
@ -265,39 +308,201 @@ ibuf_set_n64(struct ibuf *buf, size_t pos, uint64_t value)
return (ibuf_set(buf, pos, &value, sizeof(value))); return (ibuf_set(buf, pos, &value, sizeof(value)));
} }
int
ibuf_set_h16(struct ibuf *buf, size_t pos, uint64_t value)
{
uint16_t v;
if (value > UINT16_MAX) {
errno = EINVAL;
return (-1);
}
v = value;
return (ibuf_set(buf, pos, &v, sizeof(v)));
}
int
ibuf_set_h32(struct ibuf *buf, size_t pos, uint64_t value)
{
uint32_t v;
if (value > UINT32_MAX) {
errno = EINVAL;
return (-1);
}
v = value;
return (ibuf_set(buf, pos, &v, sizeof(v)));
}
int
ibuf_set_h64(struct ibuf *buf, size_t pos, uint64_t value)
{
return (ibuf_set(buf, pos, &value, sizeof(value)));
}
void * void *
ibuf_data(struct ibuf *buf) ibuf_data(const struct ibuf *buf)
{ {
return (buf->buf); return (buf->buf + buf->rpos);
} }
size_t size_t
ibuf_size(struct ibuf *buf) ibuf_size(const struct ibuf *buf)
{ {
return (buf->wpos); return (buf->wpos - buf->rpos);
} }
size_t size_t
ibuf_left(struct ibuf *buf) ibuf_left(const struct ibuf *buf)
{ {
if (buf->max == 0)
return (0);
return (buf->max - buf->wpos); return (buf->max - buf->wpos);
} }
int
ibuf_truncate(struct ibuf *buf, size_t len)
{
if (ibuf_size(buf) >= len) {
buf->wpos = buf->rpos + len;
return (0);
}
if (buf->max == 0) {
/* only allow to truncate down */
errno = ERANGE;
return (-1);
}
return ibuf_add_zero(buf, len - ibuf_size(buf));
}
void
ibuf_rewind(struct ibuf *buf)
{
buf->rpos = 0;
}
void void
ibuf_close(struct msgbuf *msgbuf, struct ibuf *buf) ibuf_close(struct msgbuf *msgbuf, struct ibuf *buf)
{ {
ibuf_enqueue(msgbuf, buf); ibuf_enqueue(msgbuf, buf);
} }
void
ibuf_from_buffer(struct ibuf *buf, void *data, size_t len)
{
memset(buf, 0, sizeof(*buf));
buf->buf = data;
buf->size = buf->wpos = len;
buf->fd = -1;
}
void
ibuf_from_ibuf(struct ibuf *buf, const struct ibuf *from)
{
ibuf_from_buffer(buf, ibuf_data(from), ibuf_size(from));
}
int
ibuf_get(struct ibuf *buf, void *data, size_t len)
{
if (ibuf_size(buf) < len) {
errno = EBADMSG;
return (-1);
}
memcpy(data, ibuf_data(buf), len);
buf->rpos += len;
return (0);
}
int
ibuf_get_ibuf(struct ibuf *buf, size_t len, struct ibuf *new)
{
if (ibuf_size(buf) < len) {
errno = EBADMSG;
return (-1);
}
ibuf_from_buffer(new, ibuf_data(buf), len);
buf->rpos += len;
return (0);
}
int
ibuf_get_n8(struct ibuf *buf, uint8_t *value)
{
return ibuf_get(buf, value, sizeof(*value));
}
int
ibuf_get_n16(struct ibuf *buf, uint16_t *value)
{
int rv;
rv = ibuf_get(buf, value, sizeof(*value));
*value = be16toh(*value);
return (rv);
}
int
ibuf_get_n32(struct ibuf *buf, uint32_t *value)
{
int rv;
rv = ibuf_get(buf, value, sizeof(*value));
*value = be32toh(*value);
return (rv);
}
int
ibuf_get_n64(struct ibuf *buf, uint64_t *value)
{
int rv;
rv = ibuf_get(buf, value, sizeof(*value));
*value = be64toh(*value);
return (rv);
}
int
ibuf_get_h16(struct ibuf *buf, uint16_t *value)
{
return ibuf_get(buf, value, sizeof(*value));
}
int
ibuf_get_h32(struct ibuf *buf, uint32_t *value)
{
return ibuf_get(buf, value, sizeof(*value));
}
int
ibuf_get_h64(struct ibuf *buf, uint64_t *value)
{
return ibuf_get(buf, value, sizeof(*value));
}
int
ibuf_skip(struct ibuf *buf, size_t len)
{
if (ibuf_size(buf) < len) {
errno = EBADMSG;
return (-1);
}
buf->rpos += len;
return (0);
}
void void
ibuf_free(struct ibuf *buf) ibuf_free(struct ibuf *buf)
{ {
if (buf == NULL) if (buf == NULL)
return; return;
#ifdef NOTYET if (buf->max == 0) /* if buf lives on the stack */
abort(); /* abort before causing more harm */
if (buf->fd != -1) if (buf->fd != -1)
close(buf->fd); close(buf->fd);
#endif
freezero(buf->buf, buf->size); freezero(buf->buf, buf->size);
free(buf); free(buf);
} }
@ -314,15 +519,15 @@ ibuf_fd_get(struct ibuf *buf)
int fd; int fd;
fd = buf->fd; fd = buf->fd;
#ifdef NOTYET
buf->fd = -1; buf->fd = -1;
#endif
return (fd); return (fd);
} }
void void
ibuf_fd_set(struct ibuf *buf, int fd) ibuf_fd_set(struct ibuf *buf, int fd)
{ {
if (buf->max == 0) /* if buf lives on the stack */
abort(); /* abort before causing more harm */
if (buf->fd != -1) if (buf->fd != -1)
close(buf->fd); close(buf->fd);
buf->fd = fd; buf->fd = fd;
@ -340,8 +545,8 @@ ibuf_write(struct msgbuf *msgbuf)
TAILQ_FOREACH(buf, &msgbuf->bufs, entry) { TAILQ_FOREACH(buf, &msgbuf->bufs, entry) {
if (i >= IOV_MAX) if (i >= IOV_MAX)
break; break;
iov[i].iov_base = buf->buf + buf->rpos; iov[i].iov_base = ibuf_data(buf);
iov[i].iov_len = buf->wpos - buf->rpos; iov[i].iov_len = ibuf_size(buf);
i++; i++;
} }
@ -380,8 +585,8 @@ msgbuf_drain(struct msgbuf *msgbuf, size_t n)
for (buf = TAILQ_FIRST(&msgbuf->bufs); buf != NULL && n > 0; for (buf = TAILQ_FIRST(&msgbuf->bufs); buf != NULL && n > 0;
buf = next) { buf = next) {
next = TAILQ_NEXT(buf, entry); next = TAILQ_NEXT(buf, entry);
if (n >= buf->wpos - buf->rpos) { if (n >= ibuf_size(buf)) {
n -= buf->wpos - buf->rpos; n -= ibuf_size(buf);
ibuf_dequeue(msgbuf, buf); ibuf_dequeue(msgbuf, buf);
} else { } else {
buf->rpos += n; buf->rpos += n;
@ -421,8 +626,8 @@ msgbuf_write(struct msgbuf *msgbuf)
break; break;
if (i > 0 && buf->fd != -1) if (i > 0 && buf->fd != -1)
break; break;
iov[i].iov_base = buf->buf + buf->rpos; iov[i].iov_base = ibuf_data(buf);
iov[i].iov_len = buf->wpos - buf->rpos; iov[i].iov_len = ibuf_size(buf);
i++; i++;
if (buf->fd != -1) if (buf->fd != -1)
buf0 = buf; buf0 = buf;
@ -469,9 +674,17 @@ again:
return (1); return (1);
} }
uint32_t
msgbuf_queuelen(struct msgbuf *msgbuf)
{
return (msgbuf->queued);
}
static void static void
ibuf_enqueue(struct msgbuf *msgbuf, struct ibuf *buf) ibuf_enqueue(struct msgbuf *msgbuf, struct ibuf *buf)
{ {
if (buf->max == 0) /* if buf lives on the stack */
abort(); /* abort before causing more harm */
TAILQ_INSERT_TAIL(&msgbuf->bufs, buf, entry); TAILQ_INSERT_TAIL(&msgbuf->bufs, buf, entry);
msgbuf->queued++; msgbuf->queued++;
} }
@ -480,12 +693,6 @@ static void
ibuf_dequeue(struct msgbuf *msgbuf, struct ibuf *buf) ibuf_dequeue(struct msgbuf *msgbuf, struct ibuf *buf)
{ {
TAILQ_REMOVE(&msgbuf->bufs, buf, entry); TAILQ_REMOVE(&msgbuf->bufs, buf, entry);
if (buf->fd != -1) {
close(buf->fd);
buf->fd = -1;
}
msgbuf->queued--; msgbuf->queued--;
ibuf_free(buf); ibuf_free(buf);
} }

256
compat/imsg.c
View File

@ -1,6 +1,7 @@
/* $OpenBSD: imsg.c,v 1.19 2023/06/19 17:19:50 claudio Exp $ */ /* $OpenBSD: imsg.c,v 1.23 2023/12/12 15:47:41 claudio Exp $ */
/* /*
* Copyright (c) 2023 Claudio Jeker <claudio@openbsd.org>
* Copyright (c) 2003, 2004 Henning Brauer <henning@openbsd.org> * Copyright (c) 2003, 2004 Henning Brauer <henning@openbsd.org>
* *
* Permission to use, copy, modify, and distribute this software for any * Permission to use, copy, modify, and distribute this software for any
@ -29,23 +30,28 @@
#include "imsg.h" #include "imsg.h"
struct imsg_fd {
TAILQ_ENTRY(imsg_fd) entry;
int fd;
};
int imsg_fd_overhead = 0; int imsg_fd_overhead = 0;
static int imsg_get_fd(struct imsgbuf *); static int imsg_dequeue_fd(struct imsgbuf *);
void void
imsg_init(struct imsgbuf *ibuf, int fd) imsg_init(struct imsgbuf *imsgbuf, int fd)
{ {
msgbuf_init(&ibuf->w); msgbuf_init(&imsgbuf->w);
memset(&ibuf->r, 0, sizeof(ibuf->r)); memset(&imsgbuf->r, 0, sizeof(imsgbuf->r));
ibuf->fd = fd; imsgbuf->fd = fd;
ibuf->w.fd = fd; imsgbuf->w.fd = fd;
ibuf->pid = getpid(); imsgbuf->pid = getpid();
TAILQ_INIT(&ibuf->fds); TAILQ_INIT(&imsgbuf->fds);
} }
ssize_t ssize_t
imsg_read(struct imsgbuf *ibuf) imsg_read(struct imsgbuf *imsgbuf)
{ {
struct msghdr msg; struct msghdr msg;
struct cmsghdr *cmsg; struct cmsghdr *cmsg;
@ -61,8 +67,8 @@ imsg_read(struct imsgbuf *ibuf)
memset(&msg, 0, sizeof(msg)); memset(&msg, 0, sizeof(msg));
memset(&cmsgbuf, 0, sizeof(cmsgbuf)); memset(&cmsgbuf, 0, sizeof(cmsgbuf));
iov.iov_base = ibuf->r.buf + ibuf->r.wpos; iov.iov_base = imsgbuf->r.buf + imsgbuf->r.wpos;
iov.iov_len = sizeof(ibuf->r.buf) - ibuf->r.wpos; iov.iov_len = sizeof(imsgbuf->r.buf) - imsgbuf->r.wpos;
msg.msg_iov = &iov; msg.msg_iov = &iov;
msg.msg_iovlen = 1; msg.msg_iovlen = 1;
msg.msg_control = &cmsgbuf.buf; msg.msg_control = &cmsgbuf.buf;
@ -80,13 +86,13 @@ again:
return (-1); return (-1);
} }
if ((n = recvmsg(ibuf->fd, &msg, 0)) == -1) { if ((n = recvmsg(imsgbuf->fd, &msg, 0)) == -1) {
if (errno == EINTR) if (errno == EINTR)
goto again; goto again;
goto fail; goto fail;
} }
ibuf->r.wpos += n; imsgbuf->r.wpos += n;
for (cmsg = CMSG_FIRSTHDR(&msg); cmsg != NULL; for (cmsg = CMSG_FIRSTHDR(&msg); cmsg != NULL;
cmsg = CMSG_NXTHDR(&msg, cmsg)) { cmsg = CMSG_NXTHDR(&msg, cmsg)) {
@ -106,7 +112,7 @@ again:
fd = ((int *)CMSG_DATA(cmsg))[i]; fd = ((int *)CMSG_DATA(cmsg))[i];
if (ifd != NULL) { if (ifd != NULL) {
ifd->fd = fd; ifd->fd = fd;
TAILQ_INSERT_TAIL(&ibuf->fds, ifd, TAILQ_INSERT_TAIL(&imsgbuf->fds, ifd,
entry); entry);
ifd = NULL; ifd = NULL;
} else } else
@ -122,77 +128,145 @@ fail:
} }
ssize_t ssize_t
imsg_get(struct imsgbuf *ibuf, struct imsg *imsg) imsg_get(struct imsgbuf *imsgbuf, struct imsg *imsg)
{ {
struct imsg m;
size_t av, left, datalen; size_t av, left, datalen;
av = ibuf->r.wpos; av = imsgbuf->r.wpos;
if (IMSG_HEADER_SIZE > av) if (IMSG_HEADER_SIZE > av)
return (0); return (0);
memcpy(&imsg->hdr, ibuf->r.buf, sizeof(imsg->hdr)); memcpy(&m.hdr, imsgbuf->r.buf, sizeof(m.hdr));
if (imsg->hdr.len < IMSG_HEADER_SIZE || if (m.hdr.len < IMSG_HEADER_SIZE ||
imsg->hdr.len > MAX_IMSGSIZE) { m.hdr.len > MAX_IMSGSIZE) {
errno = ERANGE; errno = ERANGE;
return (-1); return (-1);
} }
if (imsg->hdr.len > av) if (m.hdr.len > av)
return (0); return (0);
datalen = imsg->hdr.len - IMSG_HEADER_SIZE;
ibuf->r.rptr = ibuf->r.buf + IMSG_HEADER_SIZE;
if (datalen == 0)
imsg->data = NULL;
else if ((imsg->data = malloc(datalen)) == NULL)
return (-1);
if (imsg->hdr.flags & IMSGF_HASFD) m.fd = -1;
imsg->fd = imsg_get_fd(ibuf); m.buf = NULL;
else m.data = NULL;
imsg->fd = -1;
if (datalen != 0) datalen = m.hdr.len - IMSG_HEADER_SIZE;
memcpy(imsg->data, ibuf->r.rptr, datalen); imsgbuf->r.rptr = imsgbuf->r.buf + IMSG_HEADER_SIZE;
if (datalen != 0) {
if ((m.buf = ibuf_open(datalen)) == NULL)
return (-1);
if (ibuf_add(m.buf, imsgbuf->r.rptr, datalen) == -1) {
/* this should never fail */
ibuf_free(m.buf);
return (-1);
}
m.data = ibuf_data(m.buf);
}
if (imsg->hdr.len < av) { if (m.hdr.flags & IMSGF_HASFD)
left = av - imsg->hdr.len; m.fd = imsg_dequeue_fd(imsgbuf);
memmove(&ibuf->r.buf, ibuf->r.buf + imsg->hdr.len, left);
ibuf->r.wpos = left; if (m.hdr.len < av) {
left = av - m.hdr.len;
memmove(&imsgbuf->r.buf, imsgbuf->r.buf + m.hdr.len, left);
imsgbuf->r.wpos = left;
} else } else
ibuf->r.wpos = 0; imsgbuf->r.wpos = 0;
*imsg = m;
return (datalen + IMSG_HEADER_SIZE); return (datalen + IMSG_HEADER_SIZE);
} }
int int
imsg_compose(struct imsgbuf *ibuf, uint32_t type, uint32_t peerid, pid_t pid, imsg_get_ibuf(struct imsg *imsg, struct ibuf *ibuf)
int fd, const void *data, uint16_t datalen) {
if (imsg->buf == NULL) {
errno = EBADMSG;
return (-1);
}
return ibuf_get_ibuf(imsg->buf, ibuf_size(imsg->buf), ibuf);
}
int
imsg_get_data(struct imsg *imsg, void *data, size_t len)
{
if (len == 0) {
errno = EINVAL;
return (-1);
}
if (imsg->buf == NULL || ibuf_size(imsg->buf) != len) {
errno = EBADMSG;
return (-1);
}
return ibuf_get(imsg->buf, data, len);
}
int
imsg_get_fd(struct imsg *imsg)
{
int fd = imsg->fd;
imsg->fd = -1;
return fd;
}
uint32_t
imsg_get_id(struct imsg *imsg)
{
return (imsg->hdr.peerid);
}
size_t
imsg_get_len(struct imsg *imsg)
{
if (imsg->buf == NULL)
return 0;
return ibuf_size(imsg->buf);
}
pid_t
imsg_get_pid(struct imsg *imsg)
{
return (imsg->hdr.pid);
}
uint32_t
imsg_get_type(struct imsg *imsg)
{
return (imsg->hdr.type);
}
int
imsg_compose(struct imsgbuf *imsgbuf, uint32_t type, uint32_t id, pid_t pid,
int fd, const void *data, size_t datalen)
{ {
struct ibuf *wbuf; struct ibuf *wbuf;
if ((wbuf = imsg_create(ibuf, type, peerid, pid, datalen)) == NULL) if ((wbuf = imsg_create(imsgbuf, type, id, pid, datalen)) == NULL)
return (-1); return (-1);
if (imsg_add(wbuf, data, datalen) == -1) if (imsg_add(wbuf, data, datalen) == -1)
return (-1); return (-1);
ibuf_fd_set(wbuf, fd); ibuf_fd_set(wbuf, fd);
imsg_close(ibuf, wbuf); imsg_close(imsgbuf, wbuf);
return (1); return (1);
} }
int int
imsg_composev(struct imsgbuf *ibuf, uint32_t type, uint32_t peerid, pid_t pid, imsg_composev(struct imsgbuf *imsgbuf, uint32_t type, uint32_t id, pid_t pid,
int fd, const struct iovec *iov, int iovcnt) int fd, const struct iovec *iov, int iovcnt)
{ {
struct ibuf *wbuf; struct ibuf *wbuf;
int i, datalen = 0; int i;
size_t datalen = 0;
for (i = 0; i < iovcnt; i++) for (i = 0; i < iovcnt; i++)
datalen += iov[i].iov_len; datalen += iov[i].iov_len;
if ((wbuf = imsg_create(ibuf, type, peerid, pid, datalen)) == NULL) if ((wbuf = imsg_create(imsgbuf, type, id, pid, datalen)) == NULL)
return (-1); return (-1);
for (i = 0; i < iovcnt; i++) for (i = 0; i < iovcnt; i++)
@ -200,16 +274,20 @@ imsg_composev(struct imsgbuf *ibuf, uint32_t type, uint32_t peerid, pid_t pid,
return (-1); return (-1);
ibuf_fd_set(wbuf, fd); ibuf_fd_set(wbuf, fd);
imsg_close(ibuf, wbuf); imsg_close(imsgbuf, wbuf);
return (1); return (1);
} }
/*
* Enqueue imsg with payload from ibuf buf. fd passing is not possible
* with this function.
*/
int int
imsg_compose_ibuf(struct imsgbuf *ibuf, uint32_t type, uint32_t peerid, imsg_compose_ibuf(struct imsgbuf *imsgbuf, uint32_t type, uint32_t id,
pid_t pid, struct ibuf *buf) pid_t pid, struct ibuf *buf)
{ {
struct ibuf *wbuf = NULL; struct ibuf *hdrbuf = NULL;
struct imsg_hdr hdr; struct imsg_hdr hdr;
int save_errno; int save_errno;
@ -221,30 +299,64 @@ imsg_compose_ibuf(struct imsgbuf *ibuf, uint32_t type, uint32_t peerid,
hdr.type = type; hdr.type = type;
hdr.len = ibuf_size(buf) + IMSG_HEADER_SIZE; hdr.len = ibuf_size(buf) + IMSG_HEADER_SIZE;
hdr.flags = 0; hdr.flags = 0;
hdr.peerid = peerid; hdr.peerid = id;
if ((hdr.pid = pid) == 0) if ((hdr.pid = pid) == 0)
hdr.pid = ibuf->pid; hdr.pid = imsgbuf->pid;
if ((wbuf = ibuf_open(IMSG_HEADER_SIZE)) == NULL) if ((hdrbuf = ibuf_open(IMSG_HEADER_SIZE)) == NULL)
goto fail; goto fail;
if (imsg_add(wbuf, &hdr, sizeof(hdr)) == -1) if (imsg_add(hdrbuf, &hdr, sizeof(hdr)) == -1)
goto fail; goto fail;
ibuf_close(&ibuf->w, wbuf); ibuf_close(&imsgbuf->w, hdrbuf);
ibuf_close(&ibuf->w, buf); ibuf_close(&imsgbuf->w, buf);
return (1); return (1);
fail: fail:
save_errno = errno; save_errno = errno;
ibuf_free(buf); ibuf_free(buf);
ibuf_free(wbuf); ibuf_free(hdrbuf);
errno = save_errno; errno = save_errno;
return (-1); return (-1);
} }
/*
* Forward imsg to another channel. Any attached fd is closed.
*/
int
imsg_forward(struct imsgbuf *imsgbuf, struct imsg *msg)
{
struct ibuf *wbuf;
size_t len = 0;
if (msg->fd != -1) {
close(msg->fd);
msg->fd = -1;
}
if (msg->buf != NULL) {
ibuf_rewind(msg->buf);
len = ibuf_size(msg->buf);
}
if ((wbuf = imsg_create(imsgbuf, msg->hdr.type, msg->hdr.peerid,
msg->hdr.pid, len)) == NULL)
return (-1);
if (msg->buf != NULL) {
if (ibuf_add_buf(wbuf, msg->buf) == -1) {
ibuf_free(wbuf);
return (-1);
}
}
imsg_close(imsgbuf, wbuf);
return (1);
}
struct ibuf * struct ibuf *
imsg_create(struct imsgbuf *ibuf, uint32_t type, uint32_t peerid, pid_t pid, imsg_create(struct imsgbuf *imsgbuf, uint32_t type, uint32_t id, pid_t pid,
uint16_t datalen) size_t datalen)
{ {
struct ibuf *wbuf; struct ibuf *wbuf;
struct imsg_hdr hdr; struct imsg_hdr hdr;
@ -257,9 +369,9 @@ imsg_create(struct imsgbuf *ibuf, uint32_t type, uint32_t peerid, pid_t pid,
hdr.type = type; hdr.type = type;
hdr.flags = 0; hdr.flags = 0;
hdr.peerid = peerid; hdr.peerid = id;
if ((hdr.pid = pid) == 0) if ((hdr.pid = pid) == 0)
hdr.pid = ibuf->pid; hdr.pid = imsgbuf->pid;
if ((wbuf = ibuf_dynamic(datalen, MAX_IMSGSIZE)) == NULL) { if ((wbuf = ibuf_dynamic(datalen, MAX_IMSGSIZE)) == NULL) {
return (NULL); return (NULL);
} }
@ -270,7 +382,7 @@ imsg_create(struct imsgbuf *ibuf, uint32_t type, uint32_t peerid, pid_t pid,
} }
int int
imsg_add(struct ibuf *msg, const void *data, uint16_t datalen) imsg_add(struct ibuf *msg, const void *data, size_t datalen)
{ {
if (datalen) if (datalen)
if (ibuf_add(msg, data, datalen) == -1) { if (ibuf_add(msg, data, datalen) == -1) {
@ -281,7 +393,7 @@ imsg_add(struct ibuf *msg, const void *data, uint16_t datalen)
} }
void void
imsg_close(struct imsgbuf *ibuf, struct ibuf *msg) imsg_close(struct imsgbuf *imsgbuf, struct ibuf *msg)
{ {
struct imsg_hdr *hdr; struct imsg_hdr *hdr;
@ -292,46 +404,46 @@ imsg_close(struct imsgbuf *ibuf, struct ibuf *msg)
hdr->flags |= IMSGF_HASFD; hdr->flags |= IMSGF_HASFD;
hdr->len = ibuf_size(msg); hdr->len = ibuf_size(msg);
ibuf_close(&ibuf->w, msg); ibuf_close(&imsgbuf->w, msg);
} }
void void
imsg_free(struct imsg *imsg) imsg_free(struct imsg *imsg)
{ {
freezero(imsg->data, imsg->hdr.len - IMSG_HEADER_SIZE); ibuf_free(imsg->buf);
} }
static int static int
imsg_get_fd(struct imsgbuf *ibuf) imsg_dequeue_fd(struct imsgbuf *imsgbuf)
{ {
int fd; int fd;
struct imsg_fd *ifd; struct imsg_fd *ifd;
if ((ifd = TAILQ_FIRST(&ibuf->fds)) == NULL) if ((ifd = TAILQ_FIRST(&imsgbuf->fds)) == NULL)
return (-1); return (-1);
fd = ifd->fd; fd = ifd->fd;
TAILQ_REMOVE(&ibuf->fds, ifd, entry); TAILQ_REMOVE(&imsgbuf->fds, ifd, entry);
free(ifd); free(ifd);
return (fd); return (fd);
} }
int int
imsg_flush(struct imsgbuf *ibuf) imsg_flush(struct imsgbuf *imsgbuf)
{ {
while (ibuf->w.queued) while (imsgbuf->w.queued)
if (msgbuf_write(&ibuf->w) <= 0) if (msgbuf_write(&imsgbuf->w) <= 0)
return (-1); return (-1);
return (0); return (0);
} }
void void
imsg_clear(struct imsgbuf *ibuf) imsg_clear(struct imsgbuf *imsgbuf)
{ {
int fd; int fd;
msgbuf_clear(&ibuf->w); msgbuf_clear(&imsgbuf->w);
while ((fd = imsg_get_fd(ibuf)) != -1) while ((fd = imsg_dequeue_fd(imsgbuf)) != -1)
close(fd); close(fd);
} }

54
compat/imsg.h
View File

@ -1,6 +1,7 @@
/* $OpenBSD: imsg.h,v 1.7 2023/06/19 17:19:50 claudio Exp $ */ /* $OpenBSD: imsg.h,v 1.8 2023/12/12 15:47:41 claudio Exp $ */
/* /*
* Copyright (c) 2023 Claudio Jeker <claudio@openbsd.org>
* Copyright (c) 2006, 2007 Pierre-Yves Ritschard <pyr@openbsd.org> * Copyright (c) 2006, 2007 Pierre-Yves Ritschard <pyr@openbsd.org>
* Copyright (c) 2006, 2007, 2008 Reyk Floeter <reyk@openbsd.org> * Copyright (c) 2006, 2007, 2008 Reyk Floeter <reyk@openbsd.org>
* Copyright (c) 2003, 2004 Henning Brauer <henning@openbsd.org> * Copyright (c) 2003, 2004 Henning Brauer <henning@openbsd.org>
@ -21,7 +22,7 @@
#ifndef _IMSG_H_ #ifndef _IMSG_H_
#define _IMSG_H_ #define _IMSG_H_
#include <stdint.h> #include <sys/types.h>
#define IBUF_READ_SIZE 65535 #define IBUF_READ_SIZE 65535
#define IMSG_HEADER_SIZE sizeof(struct imsg_hdr) #define IMSG_HEADER_SIZE sizeof(struct imsg_hdr)
@ -49,11 +50,7 @@ struct ibuf_read {
size_t wpos; size_t wpos;
}; };
struct imsg_fd { struct imsg_fd;
TAILQ_ENTRY(imsg_fd) entry;
int fd;
};
struct imsgbuf { struct imsgbuf {
TAILQ_HEAD(, imsg_fd) fds; TAILQ_HEAD(, imsg_fd) fds;
struct ibuf_read r; struct ibuf_read r;
@ -76,6 +73,7 @@ struct imsg {
struct imsg_hdr hdr; struct imsg_hdr hdr;
int fd; int fd;
void *data; void *data;
struct ibuf *buf;
}; };
struct iovec; struct iovec;
@ -85,11 +83,15 @@ struct ibuf *ibuf_open(size_t);
struct ibuf *ibuf_dynamic(size_t, size_t); struct ibuf *ibuf_dynamic(size_t, size_t);
int ibuf_add(struct ibuf *, const void *, size_t); int ibuf_add(struct ibuf *, const void *, size_t);
int ibuf_add_buf(struct ibuf *, const struct ibuf *); int ibuf_add_buf(struct ibuf *, const struct ibuf *);
int ibuf_add_ibuf(struct ibuf *, const struct ibuf *);
int ibuf_add_zero(struct ibuf *, size_t); int ibuf_add_zero(struct ibuf *, size_t);
int ibuf_add_n8(struct ibuf *, uint64_t); int ibuf_add_n8(struct ibuf *, uint64_t);
int ibuf_add_n16(struct ibuf *, uint64_t); int ibuf_add_n16(struct ibuf *, uint64_t);
int ibuf_add_n32(struct ibuf *, uint64_t); int ibuf_add_n32(struct ibuf *, uint64_t);
int ibuf_add_n64(struct ibuf *, uint64_t); int ibuf_add_n64(struct ibuf *, uint64_t);
int ibuf_add_h16(struct ibuf *, uint64_t);
int ibuf_add_h32(struct ibuf *, uint64_t);
int ibuf_add_h64(struct ibuf *, uint64_t);
void *ibuf_reserve(struct ibuf *, size_t); void *ibuf_reserve(struct ibuf *, size_t);
void *ibuf_seek(struct ibuf *, size_t, size_t); void *ibuf_seek(struct ibuf *, size_t, size_t);
int ibuf_set(struct ibuf *, size_t, const void *, size_t); int ibuf_set(struct ibuf *, size_t, const void *, size_t);
@ -97,10 +99,27 @@ int ibuf_set_n8(struct ibuf *, size_t, uint64_t);
int ibuf_set_n16(struct ibuf *, size_t, uint64_t); int ibuf_set_n16(struct ibuf *, size_t, uint64_t);
int ibuf_set_n32(struct ibuf *, size_t, uint64_t); int ibuf_set_n32(struct ibuf *, size_t, uint64_t);
int ibuf_set_n64(struct ibuf *, size_t, uint64_t); int ibuf_set_n64(struct ibuf *, size_t, uint64_t);
void *ibuf_data(struct ibuf *); int ibuf_set_h16(struct ibuf *, size_t, uint64_t);
size_t ibuf_size(struct ibuf *); int ibuf_set_h32(struct ibuf *, size_t, uint64_t);
size_t ibuf_left(struct ibuf *); int ibuf_set_h64(struct ibuf *, size_t, uint64_t);
void *ibuf_data(const struct ibuf *);
size_t ibuf_size(const struct ibuf *);
size_t ibuf_left(const struct ibuf *);
int ibuf_truncate(struct ibuf *, size_t);
void ibuf_rewind(struct ibuf *);
void ibuf_close(struct msgbuf *, struct ibuf *); void ibuf_close(struct msgbuf *, struct ibuf *);
void ibuf_from_buffer(struct ibuf *, void *, size_t);
void ibuf_from_ibuf(struct ibuf *, const struct ibuf *);
int ibuf_get(struct ibuf *, void *, size_t);
int ibuf_get_ibuf(struct ibuf *, size_t, struct ibuf *);
int ibuf_get_n8(struct ibuf *, uint8_t *);
int ibuf_get_n16(struct ibuf *, uint16_t *);
int ibuf_get_n32(struct ibuf *, uint32_t *);
int ibuf_get_n64(struct ibuf *, uint64_t *);
int ibuf_get_h16(struct ibuf *, uint16_t *);
int ibuf_get_h32(struct ibuf *, uint32_t *);
int ibuf_get_h64(struct ibuf *, uint64_t *);
int ibuf_skip(struct ibuf *, size_t);
void ibuf_free(struct ibuf *); void ibuf_free(struct ibuf *);
int ibuf_fd_avail(struct ibuf *); int ibuf_fd_avail(struct ibuf *);
int ibuf_fd_get(struct ibuf *); int ibuf_fd_get(struct ibuf *);
@ -108,20 +127,29 @@ void ibuf_fd_set(struct ibuf *, int);
int ibuf_write(struct msgbuf *); int ibuf_write(struct msgbuf *);
void msgbuf_init(struct msgbuf *); void msgbuf_init(struct msgbuf *);
void msgbuf_clear(struct msgbuf *); void msgbuf_clear(struct msgbuf *);
uint32_t msgbuf_queuelen(struct msgbuf *);
int msgbuf_write(struct msgbuf *); int msgbuf_write(struct msgbuf *);
/* imsg.c */ /* imsg.c */
void imsg_init(struct imsgbuf *, int); void imsg_init(struct imsgbuf *, int);
ssize_t imsg_read(struct imsgbuf *); ssize_t imsg_read(struct imsgbuf *);
ssize_t imsg_get(struct imsgbuf *, struct imsg *); ssize_t imsg_get(struct imsgbuf *, struct imsg *);
int imsg_get_ibuf(struct imsg *, struct ibuf *);
int imsg_get_data(struct imsg *, void *, size_t);
int imsg_get_fd(struct imsg *);
uint32_t imsg_get_id(struct imsg *);
size_t imsg_get_len(struct imsg *);
pid_t imsg_get_pid(struct imsg *);
uint32_t imsg_get_type(struct imsg *);
int imsg_forward(struct imsgbuf *, struct imsg *);
int imsg_compose(struct imsgbuf *, uint32_t, uint32_t, pid_t, int, int imsg_compose(struct imsgbuf *, uint32_t, uint32_t, pid_t, int,
const void *, uint16_t); const void *, size_t);
int imsg_composev(struct imsgbuf *, uint32_t, uint32_t, pid_t, int, int imsg_composev(struct imsgbuf *, uint32_t, uint32_t, pid_t, int,
const struct iovec *, int); const struct iovec *, int);
int imsg_compose_ibuf(struct imsgbuf *, uint32_t, uint32_t, pid_t, int imsg_compose_ibuf(struct imsgbuf *, uint32_t, uint32_t, pid_t,
struct ibuf *); struct ibuf *);
struct ibuf *imsg_create(struct imsgbuf *, uint32_t, uint32_t, pid_t, uint16_t); struct ibuf *imsg_create(struct imsgbuf *, uint32_t, uint32_t, pid_t, size_t);
int imsg_add(struct ibuf *, const void *, uint16_t); int imsg_add(struct ibuf *, const void *, size_t);
void imsg_close(struct imsgbuf *, struct ibuf *); void imsg_close(struct imsgbuf *, struct ibuf *);
void imsg_free(struct imsg *); void imsg_free(struct imsg *);
int imsg_flush(struct imsgbuf *); int imsg_flush(struct imsgbuf *);