rdelaage
/
gmid
mirror of https://github.com/omar-polo/gmid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

always cast is*() arguments to unsigned char

This commit is contained in:
Omar Polo 2022-11-17 09:21:38 +00:00
parent 71cac3a08b
commit 6130e0eeac
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gg.c
View File

@ -248,7 +248,9 @@ get(const char *r)
if (memmem(buf, len, "\r\n", 2) == NULL) if (memmem(buf, len, "\r\n", 2) == NULL)
errx(1, "invalid reply: no \\r\\n"); errx(1, "invalid reply: no \\r\\n");
if (!isdigit(buf[0]) || !isdigit(buf[1]) || buf[2] != ' ') if (!isdigit((unsigned char)buf[0]) ||
!isdigit((unsigned char)buf[1]) ||
buf[2] != ' ')
errx(1, "invalid reply: invalid response format"); errx(1, "invalid reply: invalid response format");
code = (buf[0] - '0') * 10 + buf[1] - '0'; code = (buf[0] - '0') * 10 + buf[1] - '0';

5
iri.c
View File

@ -51,7 +51,8 @@ valid_pct_enc_string(char *s)
if (*s != '%') if (*s != '%')
return 1; return 1;
if (!isxdigit(s[1]) || !isxdigit(s[2])) if (!isxdigit((unsigned char)s[1]) ||
!isxdigit((unsigned char)s[2]))
return 0; return 0;
if (s[1] == '0' && s[2] == '0') if (s[1] == '0' && s[2] == '0')
@ -153,7 +154,7 @@ parse_port(struct parser *p)
p->parsed->port = p->iri; p->parsed->port = p->iri;
for (; isdigit(*p->iri); p->iri++) { for (; isdigit((unsigned char)*p->iri); p->iri++) {
i = i * 10 + *p->iri - '0'; i = i * 10 + *p->iri - '0';
if (i > UINT16_MAX) { if (i > UINT16_MAX) {
p->err = "port number too large"; p->err = "port number too large";

6
proxy.c
View File

@ -160,9 +160,9 @@ proxy_read(struct bufferevent *bev, void *d)
} }
if (len < 3 || len > 1029 || if (len < 3 || len > 1029 ||
!isdigit(hdr[0]) || !isdigit((unsigned char)hdr[0]) ||
!isdigit(hdr[1]) || !isdigit((unsigned char)hdr[1]) ||
!isspace(hdr[2])) { !isspace((unsigned char)hdr[2])) {
free(hdr); free(hdr);
log_warn(c, "upstream server is trying to send a " log_warn(c, "upstream server is trying to send a "
"header that's too long."); "header that's too long.");