2011-12-17 22:41:16 +01:00
|
|
|
/*-------------------------------------------------------------------------
|
|
|
|
*
|
|
|
|
* spginsert.c
|
|
|
|
* Externally visible index creation/insertion routines
|
|
|
|
*
|
|
|
|
* All the actual insertion logic is in spgdoinsert.c.
|
|
|
|
*
|
2019-01-02 18:44:25 +01:00
|
|
|
* Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group
|
2011-12-17 22:41:16 +01:00
|
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
|
|
*
|
|
|
|
* IDENTIFICATION
|
|
|
|
* src/backend/access/spgist/spginsert.c
|
|
|
|
*
|
|
|
|
*-------------------------------------------------------------------------
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "postgres.h"
|
|
|
|
|
|
|
|
#include "access/genam.h"
|
|
|
|
#include "access/spgist_private.h"
|
2017-02-14 21:37:59 +01:00
|
|
|
#include "access/spgxlog.h"
|
2019-03-28 03:59:06 +01:00
|
|
|
#include "access/tableam.h"
|
2014-11-06 12:52:08 +01:00
|
|
|
#include "access/xlog.h"
|
|
|
|
#include "access/xloginsert.h"
|
2011-12-17 22:41:16 +01:00
|
|
|
#include "catalog/index.h"
|
|
|
|
#include "miscadmin.h"
|
|
|
|
#include "storage/bufmgr.h"
|
|
|
|
#include "storage/smgr.h"
|
|
|
|
#include "utils/memutils.h"
|
2012-08-31 23:04:31 +02:00
|
|
|
#include "utils/rel.h"
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
|
|
|
|
typedef struct
|
|
|
|
{
|
|
|
|
SpGistState spgstate; /* SPGiST's working state */
|
2018-03-22 18:23:47 +01:00
|
|
|
int64 indtuples; /* total number of tuples indexed */
|
2011-12-17 22:41:16 +01:00
|
|
|
MemoryContext tmpCtx; /* per-tuple temporary context */
|
|
|
|
} SpGistBuildState;
|
|
|
|
|
|
|
|
|
2019-03-28 03:59:06 +01:00
|
|
|
/* Callback to process one heap tuple during table_index_build_scan */
|
2011-12-17 22:41:16 +01:00
|
|
|
static void
|
2019-11-08 09:44:52 +01:00
|
|
|
spgistBuildCallback(Relation index, ItemPointer tid, Datum *values,
|
2011-12-17 22:41:16 +01:00
|
|
|
bool *isnull, bool tupleIsAlive, void *state)
|
|
|
|
{
|
|
|
|
SpGistBuildState *buildstate = (SpGistBuildState *) state;
|
2012-03-11 21:29:04 +01:00
|
|
|
MemoryContext oldCtx;
|
2011-12-17 22:41:16 +01:00
|
|
|
|
2012-03-11 21:29:04 +01:00
|
|
|
/* Work in temp context, and reset it after each tuple */
|
|
|
|
oldCtx = MemoryContextSwitchTo(buildstate->tmpCtx);
|
2011-12-17 22:41:16 +01:00
|
|
|
|
2013-11-02 21:45:42 +01:00
|
|
|
/*
|
|
|
|
* Even though no concurrent insertions can be happening, we still might
|
|
|
|
* get a buffer-locking failure due to bgwriter or checkpointer taking a
|
|
|
|
* lock on some buffer. So we need to be willing to retry. We can flush
|
|
|
|
* any temp data when retrying.
|
|
|
|
*/
|
2019-11-08 09:44:52 +01:00
|
|
|
while (!spgdoinsert(index, &buildstate->spgstate, tid,
|
2013-11-02 21:45:42 +01:00
|
|
|
*values, *isnull))
|
|
|
|
{
|
|
|
|
MemoryContextReset(buildstate->tmpCtx);
|
|
|
|
}
|
2011-12-17 22:41:16 +01:00
|
|
|
|
2018-03-22 18:23:47 +01:00
|
|
|
/* Update total tuple count */
|
|
|
|
buildstate->indtuples += 1;
|
|
|
|
|
2012-03-11 21:29:04 +01:00
|
|
|
MemoryContextSwitchTo(oldCtx);
|
|
|
|
MemoryContextReset(buildstate->tmpCtx);
|
2011-12-17 22:41:16 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Build an SP-GiST index.
|
|
|
|
*/
|
Restructure index access method API to hide most of it at the C level.
This patch reduces pg_am to just two columns, a name and a handler
function. All the data formerly obtained from pg_am is now provided
in a C struct returned by the handler function. This is similar to
the designs we've adopted for FDWs and tablesample methods. There
are multiple advantages. For one, the index AM's support functions
are now simple C functions, making them faster to call and much less
error-prone, since the C compiler can now check function signatures.
For another, this will make it far more practical to define index access
methods in installable extensions.
A disadvantage is that SQL-level code can no longer see attributes
of index AMs; in particular, some of the crosschecks in the opr_sanity
regression test are no longer possible from SQL. We've addressed that
by adding a facility for the index AM to perform such checks instead.
(Much more could be done in that line, but for now we're content if the
amvalidate functions more or less replace what opr_sanity used to do.)
We might also want to expose some sort of reporting functionality, but
this patch doesn't do that.
Alexander Korotkov, reviewed by Petr Jelínek, and rather heavily
editorialized on by me.
2016-01-18 01:36:59 +01:00
|
|
|
IndexBuildResult *
|
|
|
|
spgbuild(Relation heap, Relation index, IndexInfo *indexInfo)
|
2011-12-17 22:41:16 +01:00
|
|
|
{
|
|
|
|
IndexBuildResult *result;
|
|
|
|
double reltuples;
|
|
|
|
SpGistBuildState buildstate;
|
|
|
|
Buffer metabuffer,
|
2012-03-11 21:29:04 +01:00
|
|
|
rootbuffer,
|
|
|
|
nullbuffer;
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
if (RelationGetNumberOfBlocks(index) != 0)
|
|
|
|
elog(ERROR, "index \"%s\" already contains data",
|
|
|
|
RelationGetRelationName(index));
|
|
|
|
|
|
|
|
/*
|
2012-03-11 21:29:04 +01:00
|
|
|
* Initialize the meta page and root pages
|
2011-12-17 22:41:16 +01:00
|
|
|
*/
|
|
|
|
metabuffer = SpGistNewBuffer(index);
|
|
|
|
rootbuffer = SpGistNewBuffer(index);
|
2012-03-11 21:29:04 +01:00
|
|
|
nullbuffer = SpGistNewBuffer(index);
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
Assert(BufferGetBlockNumber(metabuffer) == SPGIST_METAPAGE_BLKNO);
|
2012-03-11 21:29:04 +01:00
|
|
|
Assert(BufferGetBlockNumber(rootbuffer) == SPGIST_ROOT_BLKNO);
|
|
|
|
Assert(BufferGetBlockNumber(nullbuffer) == SPGIST_NULL_BLKNO);
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
START_CRIT_SECTION();
|
|
|
|
|
2016-04-20 15:31:19 +02:00
|
|
|
SpGistInitMetapage(BufferGetPage(metabuffer));
|
2011-12-17 22:41:16 +01:00
|
|
|
MarkBufferDirty(metabuffer);
|
|
|
|
SpGistInitBuffer(rootbuffer, SPGIST_LEAF);
|
|
|
|
MarkBufferDirty(rootbuffer);
|
2012-03-11 21:29:04 +01:00
|
|
|
SpGistInitBuffer(nullbuffer, SPGIST_LEAF | SPGIST_NULLS);
|
|
|
|
MarkBufferDirty(nullbuffer);
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
|
|
|
|
END_CRIT_SECTION();
|
|
|
|
|
|
|
|
UnlockReleaseBuffer(metabuffer);
|
|
|
|
UnlockReleaseBuffer(rootbuffer);
|
2012-03-11 21:29:04 +01:00
|
|
|
UnlockReleaseBuffer(nullbuffer);
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Now insert all the heap data into the index
|
|
|
|
*/
|
|
|
|
initSpGistState(&buildstate.spgstate, index);
|
|
|
|
buildstate.spgstate.isBuild = true;
|
2018-03-22 18:23:47 +01:00
|
|
|
buildstate.indtuples = 0;
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
buildstate.tmpCtx = AllocSetContextCreate(CurrentMemoryContext,
|
Phase 3 of pgindent updates.
Don't move parenthesized lines to the left, even if that means they
flow past the right margin.
By default, BSD indent lines up statement continuation lines that are
within parentheses so that they start just to the right of the preceding
left parenthesis. However, traditionally, if that resulted in the
continuation line extending to the right of the desired right margin,
then indent would push it left just far enough to not overrun the margin,
if it could do so without making the continuation line start to the left of
the current statement indent. That makes for a weird mix of indentations
unless one has been completely rigid about never violating the 80-column
limit.
This behavior has been pretty universally panned by Postgres developers.
Hence, disable it with indent's new -lpl switch, so that parenthesized
lines are always lined up with the preceding left paren.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
2017-06-21 21:35:54 +02:00
|
|
|
"SP-GiST build temporary context",
|
Add macros to make AllocSetContextCreate() calls simpler and safer.
I found that half a dozen (nearly 5%) of our AllocSetContextCreate calls
had typos in the context-sizing parameters. While none of these led to
especially significant problems, they did create minor inefficiencies,
and it's now clear that expecting people to copy-and-paste those calls
accurately is not a great idea. Let's reduce the risk of future errors
by introducing single macros that encapsulate the common use-cases.
Three such macros are enough to cover all but two special-purpose contexts;
those two calls can be left as-is, I think.
While this patch doesn't in itself improve matters for third-party
extensions, it doesn't break anything for them either, and they can
gradually adopt the simplified notation over time.
In passing, change TopMemoryContext to use the default allocation
parameters. Formerly it could only be extended 8K at a time. That was
probably reasonable when this code was written; but nowadays we create
many more contexts than we did then, so that it's not unusual to have a
couple hundred K in TopMemoryContext, even without considering various
dubious code that sticks other things there. There seems no good reason
not to let it use growing blocks like most other contexts.
Back-patch to 9.6, mostly because that's still close enough to HEAD that
it's easy to do so, and keeping the branches in sync can be expected to
avoid some future back-patching pain. The bugs fixed by these changes
don't seem to be significant enough to justify fixing them further back.
Discussion: <21072.1472321324@sss.pgh.pa.us>
2016-08-27 23:50:38 +02:00
|
|
|
ALLOCSET_DEFAULT_SIZES);
|
2011-12-17 22:41:16 +01:00
|
|
|
|
Report progress of CREATE INDEX operations
This uses the progress reporting infrastructure added by c16dc1aca5e0,
adding support for CREATE INDEX and CREATE INDEX CONCURRENTLY.
There are two pieces to this: one is index-AM-agnostic, and the other is
AM-specific. The latter is fairly elaborate for btrees, including
reportage for parallel index builds and the separate phases that btree
index creation uses; other index AMs, which are much simpler in their
building procedures, have simplistic reporting only, but that seems
sufficient, at least for non-concurrent builds.
The index-AM-agnostic part is fairly complete, providing insight into
the CONCURRENTLY wait phases as well as block-based progress during the
index validation table scan. (The index validation index scan requires
patching each AM, which has not been included here.)
Reviewers: Rahila Syed, Pavan Deolasee, Tatsuro Yamada
Discussion: https://postgr.es/m/20181220220022.mg63bhk26zdpvmcj@alvherre.pgsql
2019-04-02 20:18:08 +02:00
|
|
|
reltuples = table_index_build_scan(heap, index, indexInfo, true, true,
|
2019-03-28 03:59:06 +01:00
|
|
|
spgistBuildCallback, (void *) &buildstate,
|
|
|
|
NULL);
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
MemoryContextDelete(buildstate.tmpCtx);
|
|
|
|
|
|
|
|
SpGistUpdateMetaPage(index);
|
|
|
|
|
Generate less WAL during GiST, GIN and SP-GiST index build.
Instead of WAL-logging every modification during the build separately,
first build the index without any WAL-logging, and make a separate pass
through the index at the end, to write all pages to the WAL. This
significantly reduces the amount of WAL generated, and is usually also
faster, despite the extra I/O needed for the extra scan through the index.
WAL generated this way is also faster to replay.
For GiST, the LSN-NSN interlock makes this a little tricky. All pages must
be marked with a valid (i.e. non-zero) LSN, so that the parent-child
LSN-NSN interlock works correctly. We now use magic value 1 for that during
index build. Change the fake LSN counter to begin from 1000, so that 1 is
safely smaller than any real or fake LSN. 2 would've been enough for our
purposes, but let's reserve a bigger range, in case we need more special
values in the future.
Author: Anastasia Lubennikova, Andrey V. Lepikhov
Reviewed-by: Heikki Linnakangas, Dmitry Dolgov
2019-04-03 16:03:15 +02:00
|
|
|
/*
|
|
|
|
* We didn't write WAL records as we built the index, so if WAL-logging is
|
|
|
|
* required, write all pages to the WAL now.
|
|
|
|
*/
|
|
|
|
if (RelationNeedsWAL(index))
|
|
|
|
{
|
|
|
|
log_newpage_range(index, MAIN_FORKNUM,
|
|
|
|
0, RelationGetNumberOfBlocks(index),
|
|
|
|
true);
|
|
|
|
}
|
|
|
|
|
2011-12-17 22:41:16 +01:00
|
|
|
result = (IndexBuildResult *) palloc0(sizeof(IndexBuildResult));
|
2018-03-22 18:23:47 +01:00
|
|
|
result->heap_tuples = reltuples;
|
|
|
|
result->index_tuples = buildstate.indtuples;
|
2011-12-17 22:41:16 +01:00
|
|
|
|
Restructure index access method API to hide most of it at the C level.
This patch reduces pg_am to just two columns, a name and a handler
function. All the data formerly obtained from pg_am is now provided
in a C struct returned by the handler function. This is similar to
the designs we've adopted for FDWs and tablesample methods. There
are multiple advantages. For one, the index AM's support functions
are now simple C functions, making them faster to call and much less
error-prone, since the C compiler can now check function signatures.
For another, this will make it far more practical to define index access
methods in installable extensions.
A disadvantage is that SQL-level code can no longer see attributes
of index AMs; in particular, some of the crosschecks in the opr_sanity
regression test are no longer possible from SQL. We've addressed that
by adding a facility for the index AM to perform such checks instead.
(Much more could be done in that line, but for now we're content if the
amvalidate functions more or less replace what opr_sanity used to do.)
We might also want to expose some sort of reporting functionality, but
this patch doesn't do that.
Alexander Korotkov, reviewed by Petr Jelínek, and rather heavily
editorialized on by me.
2016-01-18 01:36:59 +01:00
|
|
|
return result;
|
2011-12-17 22:41:16 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Build an empty SPGiST index in the initialization fork
|
|
|
|
*/
|
Restructure index access method API to hide most of it at the C level.
This patch reduces pg_am to just two columns, a name and a handler
function. All the data formerly obtained from pg_am is now provided
in a C struct returned by the handler function. This is similar to
the designs we've adopted for FDWs and tablesample methods. There
are multiple advantages. For one, the index AM's support functions
are now simple C functions, making them faster to call and much less
error-prone, since the C compiler can now check function signatures.
For another, this will make it far more practical to define index access
methods in installable extensions.
A disadvantage is that SQL-level code can no longer see attributes
of index AMs; in particular, some of the crosschecks in the opr_sanity
regression test are no longer possible from SQL. We've addressed that
by adding a facility for the index AM to perform such checks instead.
(Much more could be done in that line, but for now we're content if the
amvalidate functions more or less replace what opr_sanity used to do.)
We might also want to expose some sort of reporting functionality, but
this patch doesn't do that.
Alexander Korotkov, reviewed by Petr Jelínek, and rather heavily
editorialized on by me.
2016-01-18 01:36:59 +01:00
|
|
|
void
|
|
|
|
spgbuildempty(Relation index)
|
2011-12-17 22:41:16 +01:00
|
|
|
{
|
|
|
|
Page page;
|
|
|
|
|
|
|
|
/* Construct metapage. */
|
|
|
|
page = (Page) palloc(BLCKSZ);
|
|
|
|
SpGistInitMetapage(page);
|
|
|
|
|
2016-12-08 20:09:09 +01:00
|
|
|
/*
|
|
|
|
* Write the page and log it unconditionally. This is important
|
2017-05-17 22:31:56 +02:00
|
|
|
* particularly for indexes created on tablespaces and databases whose
|
|
|
|
* creation happened after the last redo pointer as recovery removes any
|
|
|
|
* of their existing content when the corresponding create records are
|
|
|
|
* replayed.
|
2016-12-08 20:09:09 +01:00
|
|
|
*/
|
2013-03-22 14:54:07 +01:00
|
|
|
PageSetChecksumInplace(page, SPGIST_METAPAGE_BLKNO);
|
2011-12-17 22:41:16 +01:00
|
|
|
smgrwrite(index->rd_smgr, INIT_FORKNUM, SPGIST_METAPAGE_BLKNO,
|
|
|
|
(char *) page, true);
|
2016-12-08 20:09:09 +01:00
|
|
|
log_newpage(&index->rd_smgr->smgr_rnode.node, INIT_FORKNUM,
|
Set the metapage's pd_lower correctly in brin, gin, and spgist indexes.
Previously, these index types left the pd_lower field set to the default
SizeOfPageHeaderData, which is really a lie because it ought to point past
whatever space is being used for metadata. The coding accidentally failed
to fail because we never told xlog.c that the metapage is of standard
format --- but that's not very good, because it impedes WAL consistency
checking, and in some cases prevents compression of full-page images.
To fix, ensure that we set pd_lower correctly, not only when creating a
metapage but whenever we write it out (these apparently redundant steps are
needed to cope with pg_upgrade'd indexes that don't yet contain the right
value). This allows telling xlog.c that the page is of standard format.
The WAL consistency check mask functions are made to mask only if pd_lower
appears valid, which I think is likely unnecessary complication, since
any metapage appearing in a v11 WAL stream should contain valid pd_lower.
But it doesn't cost much to be paranoid.
Amit Langote, reviewed by Michael Paquier and Amit Kapila
Discussion: https://postgr.es/m/0d273805-0e9e-ec1a-cb84-d4da400b8f85@lab.ntt.co.jp
2017-11-02 22:22:08 +01:00
|
|
|
SPGIST_METAPAGE_BLKNO, page, true);
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
/* Likewise for the root page. */
|
|
|
|
SpGistInitPage(page, SPGIST_LEAF);
|
|
|
|
|
2013-03-22 14:54:07 +01:00
|
|
|
PageSetChecksumInplace(page, SPGIST_ROOT_BLKNO);
|
2012-03-11 21:29:04 +01:00
|
|
|
smgrwrite(index->rd_smgr, INIT_FORKNUM, SPGIST_ROOT_BLKNO,
|
|
|
|
(char *) page, true);
|
2016-12-08 20:09:09 +01:00
|
|
|
log_newpage(&index->rd_smgr->smgr_rnode.node, INIT_FORKNUM,
|
|
|
|
SPGIST_ROOT_BLKNO, page, true);
|
2012-03-11 21:29:04 +01:00
|
|
|
|
|
|
|
/* Likewise for the null-tuples root page. */
|
|
|
|
SpGistInitPage(page, SPGIST_LEAF | SPGIST_NULLS);
|
|
|
|
|
2013-03-22 14:54:07 +01:00
|
|
|
PageSetChecksumInplace(page, SPGIST_NULL_BLKNO);
|
2012-03-11 21:29:04 +01:00
|
|
|
smgrwrite(index->rd_smgr, INIT_FORKNUM, SPGIST_NULL_BLKNO,
|
2011-12-17 22:41:16 +01:00
|
|
|
(char *) page, true);
|
2016-12-08 20:09:09 +01:00
|
|
|
log_newpage(&index->rd_smgr->smgr_rnode.node, INIT_FORKNUM,
|
|
|
|
SPGIST_NULL_BLKNO, page, true);
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* An immediate sync is required even if we xlog'd the pages, because the
|
|
|
|
* writes did not go through shared buffers and therefore a concurrent
|
|
|
|
* checkpoint may have moved the redo pointer past our xlog record.
|
|
|
|
*/
|
|
|
|
smgrimmedsync(index->rd_smgr, INIT_FORKNUM);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Insert one new tuple into an SPGiST index.
|
|
|
|
*/
|
Restructure index access method API to hide most of it at the C level.
This patch reduces pg_am to just two columns, a name and a handler
function. All the data formerly obtained from pg_am is now provided
in a C struct returned by the handler function. This is similar to
the designs we've adopted for FDWs and tablesample methods. There
are multiple advantages. For one, the index AM's support functions
are now simple C functions, making them faster to call and much less
error-prone, since the C compiler can now check function signatures.
For another, this will make it far more practical to define index access
methods in installable extensions.
A disadvantage is that SQL-level code can no longer see attributes
of index AMs; in particular, some of the crosschecks in the opr_sanity
regression test are no longer possible from SQL. We've addressed that
by adding a facility for the index AM to perform such checks instead.
(Much more could be done in that line, but for now we're content if the
amvalidate functions more or less replace what opr_sanity used to do.)
We might also want to expose some sort of reporting functionality, but
this patch doesn't do that.
Alexander Korotkov, reviewed by Petr Jelínek, and rather heavily
editorialized on by me.
2016-01-18 01:36:59 +01:00
|
|
|
bool
|
|
|
|
spginsert(Relation index, Datum *values, bool *isnull,
|
|
|
|
ItemPointer ht_ctid, Relation heapRel,
|
Allow index AMs to cache data across aminsert calls within a SQL command.
It's always been possible for index AMs to cache data across successive
amgettuple calls within a single SQL command: the IndexScanDesc.opaque
field is meant for precisely that. However, no comparable facility
exists for amortizing setup work across successive aminsert calls.
This patch adds such a feature and teaches GIN, GIST, and BRIN to use it
to amortize catalog lookups they'd previously been doing on every call.
(The other standard index AMs keep everything they need in the relcache,
so there's little to improve there.)
For GIN, the overall improvement in a statement that inserts many rows
can be as much as 10%, though it seems a bit less for the other two.
In addition, this makes a really significant difference in runtime
for CLOBBER_CACHE_ALWAYS tests, since in those builds the repeated
catalog lookups are vastly more expensive.
The reason this has been hard up to now is that the aminsert function is
not passed any useful place to cache per-statement data. What I chose to
do is to add suitable fields to struct IndexInfo and pass that to aminsert.
That's not widening the index AM API very much because IndexInfo is already
within the ken of ambuild; in fact, by passing the same info to aminsert
as to ambuild, this is really removing an inconsistency in the AM API.
Discussion: https://postgr.es/m/27568.1486508680@sss.pgh.pa.us
2017-02-09 17:52:12 +01:00
|
|
|
IndexUniqueCheck checkUnique,
|
|
|
|
IndexInfo *indexInfo)
|
2011-12-17 22:41:16 +01:00
|
|
|
{
|
|
|
|
SpGistState spgstate;
|
|
|
|
MemoryContext oldCtx;
|
|
|
|
MemoryContext insertCtx;
|
|
|
|
|
|
|
|
insertCtx = AllocSetContextCreate(CurrentMemoryContext,
|
|
|
|
"SP-GiST insert temporary context",
|
Add macros to make AllocSetContextCreate() calls simpler and safer.
I found that half a dozen (nearly 5%) of our AllocSetContextCreate calls
had typos in the context-sizing parameters. While none of these led to
especially significant problems, they did create minor inefficiencies,
and it's now clear that expecting people to copy-and-paste those calls
accurately is not a great idea. Let's reduce the risk of future errors
by introducing single macros that encapsulate the common use-cases.
Three such macros are enough to cover all but two special-purpose contexts;
those two calls can be left as-is, I think.
While this patch doesn't in itself improve matters for third-party
extensions, it doesn't break anything for them either, and they can
gradually adopt the simplified notation over time.
In passing, change TopMemoryContext to use the default allocation
parameters. Formerly it could only be extended 8K at a time. That was
probably reasonable when this code was written; but nowadays we create
many more contexts than we did then, so that it's not unusual to have a
couple hundred K in TopMemoryContext, even without considering various
dubious code that sticks other things there. There seems no good reason
not to let it use growing blocks like most other contexts.
Back-patch to 9.6, mostly because that's still close enough to HEAD that
it's easy to do so, and keeping the branches in sync can be expected to
avoid some future back-patching pain. The bugs fixed by these changes
don't seem to be significant enough to justify fixing them further back.
Discussion: <21072.1472321324@sss.pgh.pa.us>
2016-08-27 23:50:38 +02:00
|
|
|
ALLOCSET_DEFAULT_SIZES);
|
2011-12-17 22:41:16 +01:00
|
|
|
oldCtx = MemoryContextSwitchTo(insertCtx);
|
|
|
|
|
|
|
|
initSpGistState(&spgstate, index);
|
|
|
|
|
2013-06-14 20:26:43 +02:00
|
|
|
/*
|
|
|
|
* We might have to repeat spgdoinsert() multiple times, if conflicts
|
|
|
|
* occur with concurrent insertions. If so, reset the insertCtx each time
|
2014-05-06 18:12:18 +02:00
|
|
|
* to avoid cumulative memory consumption. That means we also have to
|
2013-06-14 20:26:43 +02:00
|
|
|
* redo initSpGistState(), but it's cheap enough not to matter.
|
|
|
|
*/
|
|
|
|
while (!spgdoinsert(index, &spgstate, ht_ctid, *values, *isnull))
|
|
|
|
{
|
|
|
|
MemoryContextReset(insertCtx);
|
|
|
|
initSpGistState(&spgstate, index);
|
|
|
|
}
|
2011-12-17 22:41:16 +01:00
|
|
|
|
|
|
|
SpGistUpdateMetaPage(index);
|
|
|
|
|
|
|
|
MemoryContextSwitchTo(oldCtx);
|
|
|
|
MemoryContextDelete(insertCtx);
|
|
|
|
|
|
|
|
/* return false since we've not done any unique check */
|
Restructure index access method API to hide most of it at the C level.
This patch reduces pg_am to just two columns, a name and a handler
function. All the data formerly obtained from pg_am is now provided
in a C struct returned by the handler function. This is similar to
the designs we've adopted for FDWs and tablesample methods. There
are multiple advantages. For one, the index AM's support functions
are now simple C functions, making them faster to call and much less
error-prone, since the C compiler can now check function signatures.
For another, this will make it far more practical to define index access
methods in installable extensions.
A disadvantage is that SQL-level code can no longer see attributes
of index AMs; in particular, some of the crosschecks in the opr_sanity
regression test are no longer possible from SQL. We've addressed that
by adding a facility for the index AM to perform such checks instead.
(Much more could be done in that line, but for now we're content if the
amvalidate functions more or less replace what opr_sanity used to do.)
We might also want to expose some sort of reporting functionality, but
this patch doesn't do that.
Alexander Korotkov, reviewed by Petr Jelínek, and rather heavily
editorialized on by me.
2016-01-18 01:36:59 +01:00
|
|
|
return false;
|
2011-12-17 22:41:16 +01:00
|
|
|
}
|