Commit Graph

28497 Commits

Author SHA1 Message Date
Tom Lane
6382448cf9 For bulk write operations (eg COPY IN), use a ring buffer of 16MB instead
of the 256KB limit originally enforced by a patch committed 2008-11-06.
Per recent test results, the smaller size resulted in an undesirable decrease
in bulk data loading speed, due to COPY processing frequently getting blocked
for WAL flushing.  This area might need more tweaking later, but this setting
seems to be good enough for 8.4.
2009-06-22 20:04:28 +00:00
Tom Lane
3f1e529e78 Make to_timestamp and friends skip leading spaces before an integer field,
even when not in FM mode.  This improves compatibility with Oracle and with
our pre-8.4 behavior, as per bug #4862.

Brendan Jurd

Add a couple of regression test cases for this.  In passing, get rid of the
labeling of the individual test cases; doesn't seem to be good for anything
except causing extra work when inserting a test...

Tom Lane
2009-06-22 17:54:30 +00:00
Peter Eisentraut
18df0ffbd2 Add more explicit note that the parameters of MOVE are identical to FETCH.
per David Wheeler
2009-06-22 07:12:50 +00:00
Tom Lane
1c8f03d4de Revert dubious message wording change. 2009-06-22 04:37:18 +00:00
Peter Eisentraut
e8ec0b15a0 Message fixes 2009-06-21 20:15:32 +00:00
Tom Lane
82480e28f5 Fix things so that array_agg_finalfn does not modify or free its input
ArrayBuildState, per trouble report from Merlin Moncure.  By adopting
this fix, we are essentially deciding that aggregate final-functions
should not modify their inputs ever.  Adjust documentation and comments
to match that conclusion.
2009-06-20 18:45:28 +00:00
Peter Eisentraut
87698ffa8e Extend man page installation hackery so that the man page section is also
fixed up in the .so links.
2009-06-19 19:15:13 +00:00
Peter Eisentraut
c79b4505c1 Don't convert the man page names to lower case, so that the .so links work.
This is pretty much a workaround for incomplete tools, but having the man
page names in upper case looks more natural anyway.
2009-06-19 19:14:25 +00:00
Peter Eisentraut
6f1286c12d Add manvolnum, so that man pages are generated. 2009-06-19 15:28:25 +00:00
Peter Eisentraut
a091ac46ca Don't attempt to "rm" directories on uninstall. 2009-06-18 15:10:35 +00:00
Peter Eisentraut
95289ea90b Recursive Joins -> Recursive Queries
per Erik Rijkers
2009-06-18 14:42:08 +00:00
Peter Eisentraut
9405b16f3a Add some more documentation and cross-links on using dblink with SQL/MED. 2009-06-18 14:34:36 +00:00
Peter Eisentraut
12bc87e09b Refine the use of terminology around bound and unbound cursors and cursor
variables. Remove the confusing term "reference cursor".
2009-06-18 10:22:09 +00:00
Heikki Linnakangas
efa8544fd5 Fix a few errors in comments. Patch by Fujii Masao, plus the one in
visibilitymap.c by me.
2009-06-18 10:08:08 +00:00
Tom Lane
f08e5e92e8 Fix the just-reported problem that you can't specify all four trigger event
types in CREATE TRIGGER.  While at it, clean up the amazingly tedious and
inextensible way that the trigger event type list was handled.  Per report
from Greg Sabino Mullane.
2009-06-18 01:27:02 +00:00
Tom Lane
c30446b9c9 Proofreading for Bruce's recent round of documentation proofreading.
Most of those changes were good, but some not so good ...
2009-06-17 21:58:49 +00:00
Tom Lane
e8d78d35f4 ExecAgg() failed to finish running out set-returning functions in the last
aggregated tuple of a run.  Per report from Laurenz Albe.  This is a new
bug in 8.4, but only because prior versions rejected SRFs in an Agg plan
node altogether.
2009-06-17 16:05:34 +00:00
Peter Eisentraut
5126826c52 Add another link of a GUC variable to where it is explained. 2009-06-17 13:59:28 +00:00
Peter Eisentraut
33d48d975f Fix typo in error message: tgargv -> tg_argv 2009-06-17 13:46:12 +00:00
Tom Lane
f51c9a6665 Change test tables in copy2 regression test to be temporary tables.
This prevents autovacuum from reclaiming free space in them and causing
the test's output row order to change, which is causing intermittent
bogus failure reports in the buildfarm.

Backpatch to 8.3.  The issue exists further back, but since autovacuum was
not on by default before 8.3, it's not a problem for buildfarm testing.
2009-06-14 00:00:24 +00:00
Tom Lane
5f6a14077b Fix get_sort_group_operators() so that it doesn't think arrays can be grouped
via hashing.  Eventually we ought to make that possible, but it won't happen
for 8.4.  Per yesterday's report from Robert Haas.
2009-06-13 15:42:09 +00:00
Peter Eisentraut
215ea9b455 Tweak the display of incoming foreign-key constraints in \d, per discussion
on hackers.  Also, take that string out of the translation roster, since
it's now entirely pseudo-SQL.
2009-06-13 13:43:34 +00:00
Tom Lane
a0a3883dd9 Improve documentation about GiST opclass support functions.
Dimitri Fontaine
2009-06-12 19:48:53 +00:00
Tom Lane
bfd06a713b Fix several places where a function was declared static and then defined
without static.  Per testing with a compiler that complains about this.
2009-06-12 16:17:29 +00:00
Tom Lane
63e183ca46 Add info about minimum recommended AIX fix levels, per Laurenz Albe. 2009-06-12 15:53:32 +00:00
Marc G. Fournier
35daaa91d3 time to tag rc1 ... 2009-06-12 05:19:22 +00:00
Bruce Momjian
838d74d0ce Tighten typedef check for Linux. 2009-06-12 03:09:07 +00:00
Bruce Momjian
1ef4eeef65 Mention BSD/OS find_typedef behavior. 2009-06-12 03:04:48 +00:00
Bruce Momjian
6e8d957d35 Document struct/union problem with pgindent. 2009-06-11 22:21:44 +00:00
Tom Lane
ae8a2d1a3a Update release notes to today. 2009-06-11 21:44:26 +00:00
Tom Lane
44aa60fa7c Revisit AlterTableCreateToastTable's API once again, hoping to make it what
pg_migrator actually needs and not just a partial solution.  We have to be
able to specify the OID that the new toast table should be created with.
2009-06-11 20:46:11 +00:00
Tom Lane
db16e77349 Remove our inadequate kluge that tried to get AIX's various broken versions
of getaddrinfo() to work.  Instead, recommend updating the OS to get a working
version of getaddrinfo.  Per recent discussions.
2009-06-11 19:00:15 +00:00
Tom Lane
d94582f4f8 Mark contrib's GiST and GIN opclass support functions as STRICT, for safety.
(Note: GiST penalty functions could possibly be non-strict, but none are at
present.)
2009-06-11 18:30:03 +00:00
Tom Lane
4c8175278f Update time zone data files to tzdata release 2009i: DST law changes in
Bangladesh, Egypt, Jordan, Pakistan.
2009-06-11 17:45:38 +00:00
Tom Lane
0c19f05803 Fix things so that you can still do "select foo()" where foo is a SQL
function returning setof record.  This used to work, more or less
accidentally, but I had broken it while extending the code to allow
materialize-mode functions to be called in select lists.  Add a regression
test case so it doesn't get broken again.  Per gripe from Greg Davidson.
2009-06-11 17:25:39 +00:00
Tom Lane
772a074d4a Somebody seems to have thought they could get away without checking for
rsinfo->expectedDesc == NULL in deflist_to_tuplestore(), but that doesn't
look very safe to me.  Noted in passing while studying problem report
from Greg Davidson.
2009-06-11 16:14:18 +00:00
Bruce Momjian
d747140279 8.4 pgindent run, with new combined Linux/FreeBSD/MinGW typedef list
provided by Andrew.
2009-06-11 14:49:15 +00:00
Bruce Momjian
4e86efb4e5 Add FreeBSD support for find_typedef, per request from Andrew. 2009-06-11 03:14:08 +00:00
Peter Eisentraut
0b7b908882 Translation updates 2009-06-10 23:42:44 +00:00
Peter Eisentraut
0465c52b00 Arrange that the string "syntax error" generated by bison is translated. 2009-06-10 23:11:52 +00:00
Tom Lane
14ba9fdef6 Fix ill-advised whitespace prettification, per buildfarm. 2009-06-10 23:03:32 +00:00
Peter Eisentraut
125a5b95d8 Clarify to the translator that plpgsql_yyerror() deals with the translation
of "syntax error", not the literal string.

This same change was made in the backend a while ago; but it applies to
plpgsql as well.
2009-06-10 22:34:11 +00:00
Tom Lane
15a3fe6d63 Properly mark pg_freespace() function as strict. Also update
uninstall script to match reality.
2009-06-10 22:12:28 +00:00
Peter Eisentraut
5e29862aa2 Clarify error message 2009-06-10 21:51:56 +00:00
Tom Lane
cb10e3af3a Support Kerberos on platforms where libcom_err depends on OpenSSL, as
reportedly is true on OpenBSD.  Also support OpenBSD's spelling of
-Wl,--as-needed.  Per Simon Bertrang.
2009-06-10 21:24:11 +00:00
Tom Lane
14180f9214 Add warning that xpath() doesn't work with non-UTF8 data. 2009-06-10 20:25:41 +00:00
Peter Eisentraut
746c28a8e4 Improve capitalization and punctuation in recently added GiST message. 2009-06-10 20:02:15 +00:00
Tom Lane
661b3e79c4 Add a warning about possible strange behavior of volatile functions
in cursors.  This has always been the case, but given the lack of user
complaints about it, I'm not going to bother back-patching this.
2009-06-10 19:21:37 +00:00
Tom Lane
61dd4185ff Keep rs_startblock the same during heap_rescan, so that a rescan of a SeqScan
node starts from the same place as the first scan did.  This avoids surprising
behavior of scrollable and WITH HOLD cursors, as seen in Mark Kirkwood's bug
report of yesterday.

It's not entirely clear whether a rescan should be forced to drop out of the
syncscan mode, but for the moment I left the code behaving the same on that
point.  Any change there would only be a performance and not a correctness
issue, anyway.

Back-patch to 8.3, since the unstable behavior was created by the syncscan
patch.
2009-06-10 18:54:16 +00:00
Tom Lane
2ef8c1acfd Fix cash_in() to behave properly in locales where frac_digits is zero,
eg Japan.  Report and fix by Itagaki Takahiro.  Also fix CASHDEBUG printout
format for branches with 64-bit money type, and some minor comment cleanup.

Back-patch to 7.4, because it's broken all the way back.
2009-06-10 16:31:32 +00:00