Dean Rasheed ed4653db8c Further fixing for multi-row VALUES lists for updatable views. ... Previously, rewriteTargetListIU() generated a list of attribute numbers from the targetlist, which were passed to rewriteValuesRTE(), which expected them to contain the same number of entries as there are columns in the VALUES RTE, and to be in the same order. That was fine when the target relation was a table, but for an updatable view it could be broken in at least three different ways --- rewriteTargetListIU() could insert additional targetlist entries for view columns with defaults, the view columns could be in a different order from the columns of the underlying base relation, and targetlist entries could be merged together when assigning to elements of an array or composite type. As a result, when recursing to the base relation, the list of attribute numbers generated from the rewritten targetlist could no longer be relied upon to match the columns of the VALUES RTE. We got away with that prior to 41531e42d3 because it used to always be the case that rewriteValuesRTE() did nothing for the underlying base relation, since all DEFAULTS had already been replaced when it was initially invoked for the view, but that was incorrect because it failed to apply defaults from the base relation. Fix this by examining the targetlist entries more carefully and picking out just those that are simple Vars referencing the VALUES RTE. That's sufficient for the purposes of rewriteValuesRTE(), which is only responsible for dealing with DEFAULT items in the VALUES RTE. Any DEFAULT item in the VALUES RTE that doesn't have a matching simple-Var-assignment in the targetlist is an error which we complain about, but in theory that ought to be impossible. Additionally, move this code into rewriteValuesRTE() to give a clearer separation of concerns between the 2 functions. There is no need for rewriteTargetListIU() to know about the details of the VALUES RTE. While at it, fix the comment for rewriteValuesRTE() which claimed that it doesn't support array element and field assignments --- that hasn't been true since a3c7a993d5 (9.6 and later). Back-patch to all supported versions, with minor differences for the pre-9.6 branches, which don't support array element and field assignments to the same column in multi-row VALUES lists. Reviewed by Amit Langote. Discussion: https://postgr.es/m/15623-5d67a46788ec8b7f@postgresql.org		2019-03-03 10:51:13 +00:00
..
access	Clear the local map when not used.	2019-03-01 07:38:47 +05:30
bootstrap	Remove argument isprimary from index_build()	2019-01-24 07:57:09 +09:00
catalog	Move code for managing PartitionDescs into a new file, partdesc.c	2019-02-21 11:45:02 -05:00
commands	Initialize variable to silence compiler warning.	2019-02-27 09:14:34 -08:00
executor	Use a virtual rather than a heap slot in two places where that suffices.	2019-03-01 17:26:43 -08:00
foreign	Update copyright for 2019	2019-01-02 12:44:25 -05:00
jit	Renaming for new subscripting mechanism	2019-02-01 12:50:32 -03:00
lib	Make use of compiler builtins and/or assembly for CLZ, CTZ, POPCNT.	2019-02-15 23:22:33 -05:00
libpq	Get rid of another unconstify through API changes	2019-02-14 20:44:47 +01:00
main	Replace @postgresql.org with @lists.postgresql.org for mailinglists	2019-01-19 19:06:35 +01:00
nodes	Allow user control of CTE materialization, and change the default behavior.	2019-02-16 16:11:12 -05:00
optimizer	Teach optimizer's predtest.c more things about ScalarArrayOpExpr.	2019-03-01 17:14:17 -05:00
parser	Standardize some more loops that chase down parallel lists.	2019-02-28 14:25:01 -05:00
partitioning	Move code for managing PartitionDescs into a new file, partdesc.c	2019-02-21 11:45:02 -05:00
po	Translation updates	2018-06-25 12:37:18 +02:00
port	Add shared_memory_type GUC.	2019-02-03 12:47:26 +01:00
postmaster	Report correct name in autovacuum "work items" activity	2019-02-22 13:00:16 -03:00
regex	Update copyright for 2019	2019-01-02 12:44:25 -05:00
replication	Use a virtual rather than a heap slot in two places where that suffices.	2019-03-01 17:26:43 -08:00
rewrite	Further fixing for multi-row VALUES lists for updatable views.	2019-03-03 10:51:13 +00:00
snowball	Update copyright for 2019	2019-01-02 12:44:25 -05:00
statistics	Rename nodes/relation.h to nodes/pathnodes.h.	2019-01-29 16:49:25 -05:00
storage	Clear the local map when not used.	2019-03-01 07:38:47 +05:30
tcop	More unconstify use	2019-02-13 11:50:16 +01:00
tsearch	Update copyright for 2019	2019-01-02 12:44:25 -05:00
utils	Consider only relations part of partition trees in partition functions	2019-03-02 18:18:59 +09:00
.gitignore	Add .gitignore entries for AIX-specific intermediate build artifacts.	2015-07-08 20:44:22 -04:00
common.mk	Remove PARTIAL_LINKING build mode.	2018-03-30 17:33:04 -07:00
Makefile	Ensure link commands list *.o files before LDFLAGS.	2019-01-02 13:57:54 -05:00
nls.mk	Translation updates	2018-06-25 12:37:18 +02:00